-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-134262: Add retries to downloads in PCbuild\get_external.py
#134820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Thanks @emmatyping for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…ythonGH-134820) (cherry picked from commit e9d845b) Co-authored-by: Emma Smith <emma@emmatyping.dev>
…ythonGH-134820) (cherry picked from commit e9d845b) Co-authored-by: Emma Smith <emma@emmatyping.dev>
GH-134865 is a backport of this pull request to the 3.14 branch. |
GH-134866 is a backport of this pull request to the 3.13 branch. |
Thanks! |
reporthook=reporthook, | ||
) | ||
except ConnectionError as ex: | ||
if attempt == max_retries: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because attempt
comes from range(max_retries)
, this condition can never be hit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♀️ thanks for catching that, opened #134867
|
Saw this failure https://github.com/python/cpython/actions/runs/15281482989/job/42981406933?pr=134802 and thought we could also add retries to the downloads here to avoid flakiness.