Skip to content

gh-134262: Add retries to downloads in PCbuild\get_external.py #134820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

emmatyping
Copy link
Member

@emmatyping emmatyping commented May 28, 2025

Saw this failure https://github.com/python/cpython/actions/runs/15281482989/job/42981406933?pr=134802 and thought we could also add retries to the downloads here to avoid flakiness.

@emmatyping emmatyping requested a review from hugovk May 28, 2025 02:45
@emmatyping emmatyping requested a review from a team as a code owner May 28, 2025 02:45
@emmatyping emmatyping added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 28, 2025
emmatyping and others added 2 commits May 28, 2025 11:57
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
@zooba zooba merged commit e9d845b into python:main May 28, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @emmatyping for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
…ythonGH-134820)

(cherry picked from commit e9d845b)

Co-authored-by: Emma Smith <emma@emmatyping.dev>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
…ythonGH-134820)

(cherry picked from commit e9d845b)

Co-authored-by: Emma Smith <emma@emmatyping.dev>
@bedevere-app
Copy link

bedevere-app bot commented May 28, 2025

GH-134865 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 28, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 28, 2025

GH-134866 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 28, 2025
@zooba
Copy link
Member

zooba commented May 28, 2025

Thanks!

reporthook=reporthook,
)
except ConnectionError as ex:
if attempt == max_retries:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because attempt comes from range(max_retries), this condition can never be hit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️ thanks for catching that, opened #134867

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit e9d845b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/11482) and take a look at the build logs.
  4. Check if the failure is related to this commit (e9d845b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/11482

Failed tests:

  • test_cppext
  • test_compileall
  • test.test_multiprocessing_fork.test_processes
  • test.test_concurrent_futures.test_interpreter_pool

Failed subtests:

  • test_build_cpp03 - test.test_cppext.TestCPPExt.test_build_cpp03
  • test_submit_exception_in_func - test.test_concurrent_futures.test_interpreter_pool.InterpreterPoolExecutorTest.test_submit_exception_in_func
  • test_symlink_loop - test.test_compileall.CommandLineTestsNoSourceEpoch.test_symlink_loop
  • test_build_limited_cpp03 - test.test_cppext.TestCPPExt.test_build_limited_cpp03
  • test_thread_safety - test.test_multiprocessing_fork.test_processes.WithProcessesTestFinalize.test_thread_safety
  • test_no_args_respects_force_flag - test.test_compileall.CommandLineTestsNoSourceEpoch.test_no_args_respects_force_flag

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_cppext/__init__.py", line 39, in test_build_limited_cpp03
    self.check_build('_test_limited_cpp03ext', std='c++03', limited=True)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_cppext/__init__.py", line 57, in check_build
    with support.setup_venv_with_pip_setuptools(venv_dir) as python_exe:
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/contextlib.py", line 141, in __enter__
    return next(self.gen)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 2474, in setup_venv_with_pip_setuptools
    run_command(cmd)
    ~~~~~~~~~~~^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 2449, in run_command
    subprocess.run(cmd, check=True)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/subprocess.py", line 577, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '('/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/wheeldata/setuptools-79.0.1-py3-none-any.whl')' died with <Signals.SIGSEGV: 11>.


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_cppext/__init__.py", line 39, in test_build_limited_cpp03
    self.check_build('_test_limited_cpp03ext', std='c++03', limited=True)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_cppext/__init__.py", line 58, in check_build
    self._check_build(extension_name, python_exe,
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                      std=std, limited=limited)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_cppext/__init__.py", line 95, in _check_build
    run_cmd('Install', cmd)
    ~~~~~~~^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_cppext/__init__.py", line 76, in run_cmd
    subprocess.run(cmd, check=True, env=env)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/subprocess.py", line 577, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1198027æ/tempcwd/env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1198027æ/tempcwd/pkg', '-v']' returned non-zero exit status 1.


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_concurrent_futures/util.py", line 62, in tearDown
    self.executor.shutdown(wait=True)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/concurrent/futures/thread.py", line 273, in shutdown
    t.join()
    ^^^^^^
AttributeError: 'InterpreterPoolExecutor' object has no attribute 'join'


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/cli/base_command.py", line 105, in _run_wrapper
    status = _inner_run()
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/cli/base_command.py", line 96, in _inner_run
    return self.run(options, args)
           ~~~~~~~~^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/cli/req_command.py", line 68, in wrapper
    return func(self, options, args)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/commands/install.py", line 387, in run
    requirement_set = resolver.resolve(
        reqs, check_supported_wheels=not options.target_dir
    )
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 77, in resolve
    collected = self.factory.collect_root_requirements(root_reqs)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/resolution/resolvelib/factory.py", line 545, in collect_root_requirements
    reqs = list(
        self._make_requirements_from_install_req(
    ...<2 lines>...
        )
    )
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/resolution/resolvelib/factory.py", line 501, in _make_requirements_from_install_req
    cand = self._make_base_candidate_from_link(
        ireq.link,
    ...<2 lines>...
        version=None,
    )
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/resolution/resolvelib/factory.py", line 233, in _make_base_candidate_from_link
    self._link_candidate_cache[link] = LinkCandidate(
                                       ~~~~~~~~~~~~~^
        link,
        ^^^^^
    ...<3 lines>...
        version=version,
        ^^^^^^^^^^^^^^^^
    )
    ^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/resolution/resolvelib/candidates.py", line 306, in __init__
    super().__init__(
    ~~~~~~~~~~~~~~~~^
        link=link,
        ^^^^^^^^^^
    ...<4 lines>...
        version=version,
        ^^^^^^^^^^^^^^^^
    )
    ^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/resolution/resolvelib/candidates.py", line 159, in __init__
    self.dist = self._prepare()
                ~~~~~~~~~~~~~^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/resolution/resolvelib/candidates.py", line 236, in _prepare
    dist = self._prepare_distribution()
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/resolution/resolvelib/candidates.py", line 317, in _prepare_distribution
    return preparer.prepare_linked_requirement(self._ireq, parallel_builds=True)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/operations/prepare.py", line 532, in prepare_linked_requirement
    return self._prepare_linked_requirement(req, parallel_builds)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/operations/prepare.py", line 647, in _prepare_linked_requirement
    dist = _get_prepared_distribution(
        req,
    ...<3 lines>...
        self.check_build_deps,
    )
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/operations/prepare.py", line 71, in _get_prepared_distribution
    abstract_dist.prepare_distribution_metadata(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        finder, build_isolation, check_build_deps
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/distributions/sdist.py", line 69, in prepare_distribution_metadata
    self.req.prepare_metadata()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/req/req_install.py", line 575, in prepare_metadata
    self.metadata_directory = generate_metadata(
                              ~~~~~~~~~~~~~~~~~^
        build_env=self.build_env,
        ^^^^^^^^^^^^^^^^^^^^^^^^^
        backend=self.pep517_backend,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        details=details,
        ^^^^^^^^^^^^^^^^
    )
    ^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/operations/build/metadata.py", line 34, in generate_metadata
    distinfo_dir = backend.prepare_metadata_for_build_wheel(metadata_dir)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/utils/misc.py", line 723, in prepare_metadata_for_build_wheel
    return super().prepare_metadata_for_build_wheel(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        metadata_directory=metadata_directory,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        config_settings=cs,
        ^^^^^^^^^^^^^^^^^^^
        _allow_fallback=_allow_fallback,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_vendor/pyproject_hooks/_impl.py", line 224, in prepare_metadata_for_build_wheel
    return self._call_hook(
           ~~~~~~~~~~~~~~~^
        "prepare_metadata_for_build_wheel",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<4 lines>...
        },
        ^^
    )
    ^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_vendor/pyproject_hooks/_impl.py", line 392, in _call_hook
    self._subprocess_runner(
    ~~~~~~~~~~~~~~~~~~~~~~~^
        [python, abspath(str(script)), hook_name, td],
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        cwd=self.source_dir,
        ^^^^^^^^^^^^^^^^^^^^
        extra_environ=extra_environ,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/utils/subprocess.py", line 237, in runner
    call_subprocess(
    ~~~~~~~~~~~~~~~^
        cmd,
        ^^^^
    ...<3 lines>...
        spinner=spinner,
        ^^^^^^^^^^^^^^^^
    )
    ^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/utils/subprocess.py", line 158, in call_subprocess
    log_subprocess(line)
    ~~~~~~~~~~~~~~^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/utils/_log.py", line 23, in verbose
    return self.log(VERBOSE, msg, *args, **kwargs)
           ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/logging/__init__.py", line 1592, in log
    self._log(level, msg, args, **kwargs)
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/logging/__init__.py", line 1667, in _log
    self.handle(record)
    ~~~~~~~~~~~^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/logging/__init__.py", line 1686, in handle
    self.callHandlers(record)
    ~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/logging/__init__.py", line 1744, in callHandlers
    hdlr.handle(record)
    ~~~~~~~~~~~^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/logging/__init__.py", line 1027, in handle
    self.emit(record)
    ~~~~~~~~~^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/utils/logging.py", line 186, in emit
    message = self.format(record)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/logging/__init__.py", line 999, in format
    return fmt.format(record)
           ~~~~~~~~~~^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/utils/logging.py", line 114, in format
    formatted = super().format(record)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/logging/__init__.py", line 712, in format
    record.message = record.getMessage()
                     ^^^^^^^^^^^^^^^^^
AttributeError: 'RichPipStreamHandler' object has no attribute 'getMessage'
/root/buildarea/3.x.angelico-debian-amd64/build/Lib/subprocess.py:1138: ResourceWarning: subprocess 1196506 is still running
  _warn("subprocess %s is still running" % self.pid,
/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/lib/python3.15/site-packages/pip/_internal/cli/base_command.py:148: ResourceWarning: unclosed file <_io.TextIOWrapper name=5 encoding='UTF-8'>
  return UNKNOWN_ERROR
ERROR


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_py_compile.py", line 22, in wrapper
    return fxn(*args, **kwargs)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_compileall.py", line 730, in test_symlink_loop
    self.assertRunOK('-q', self.pkgdir)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_compileall.py", line 559, in assertRunOK
    rc, out, err = script_helper.assert_python_ok(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
                     *self._get_run_args(args), **env_vars,
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                     PYTHONIOENCODING='utf-8')
                     ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line 182, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line 167, in _assert_python
    res.fail(cmd_line)
    ~~~~~~~~^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line 80, in fail
    raise AssertionError(f"Process return code is {exitcode}\n"
    ...<10 lines>...
                         f"---")
AssertionError: Process return code is -11 (SIGSEGV)
command line: ['/root/buildarea/3.x.angelico-debian-amd64/build/python', '-X', 'faulthandler', '-S', '-m', 'compileall', '-q', '/tmp/test_python_d9jvvlrh/tmpc2fsmomo/foo']


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_cppext/__init__.py", line 35, in test_build_cpp03
    self.check_build('_testcpp03ext', std='c++03')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_cppext/__init__.py", line 58, in check_build
    self._check_build(extension_name, python_exe,
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                      std=std, limited=limited)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_cppext/__init__.py", line 95, in _check_build
    run_cmd('Install', cmd)
    ~~~~~~~^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_cppext/__init__.py", line 76, in run_cmd
    subprocess.run(cmd, check=True, env=env)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/subprocess.py", line 577, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/env/bin/python', '-X', 'dev', '-m', 'pip', 'install', '--no-build-isolation', '/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_1196387æ/tempcwd/pkg', '-v']' returned non-zero exit status 2.


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 4994, in test_thread_safety
    raise exc
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 4978, in make_finalizers
    d[random.getrandbits(5)] = {Foo() for i in range(10)}
                                ~~~^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 4955, in __init__
    util.Finalize(self, cb, exitpriority=random.randint(1, 100))
                                         ~~~~~~~~~~~~~~^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/random.py", line 342, in randint
    return a + self._randbelow(b - a + 1)
               ~~~~~~~~~~~~~~~^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/random.py", line 249, in _randbelow_with_getrandbits
    r = self.getrandbits(k)  # 0 <= r < 2**k
TypeError: 'Random' object cannot be interpreted as an integer


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_py_compile.py", line 22, in wrapper
    return fxn(*args, **kwargs)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_py_compile.py", line 22, in wrapper
    return fxn(*args, **kwargs)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_compileall.py", line 593, in test_no_args_respects_force_flag
    self.assertRunOK(**env)
    ~~~~~~~~~~~~~~~~^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_compileall.py", line 562, in assertRunOK
    self.assertEqual(b'', err)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^
AssertionError: b'' != b'Exception ignored while calling weakref c[248 chars]y)\n'

@emmatyping emmatyping deleted the retry-externals-too branch May 28, 2025 21:45
zooba pushed a commit that referenced this pull request May 28, 2025
…4820)

(cherry picked from commit e9d845b)

Co-authored-by: Emma Smith <emma@emmatyping.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants