Skip to content

gh-127146: Report uid in Emscripten + node as native uid #136509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jul 10, 2025

Fixes test_netrc.NetrcTestCase.test_security, which was getting mad that we reported the uid of a file correctly but reported the user's uid as 0.

cc @freakboy3742.

Fixes `test_netrc.NetrcTestCase.test_security`, which was getting mad
that we reported the uid of a file correctly but reported the user's uid
as 0.
@freakboy3742
Copy link
Contributor

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit f2a7202 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136509%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@freakboy3742
Copy link
Contributor

freakboy3742 commented Jul 11, 2025

The buildbot isn't happy with the new C file...

@hoodmane
Copy link
Contributor Author

Indeed, there is a missing #include.
!buildbot emscripten

@hoodmane
Copy link
Contributor Author

How do the !buildbot pragmas work? I don't find a section the devguide https://devguide.python.org/testing/buildbots/ Maybe we should add a paragraph there explaining.

@freakboy3742
Copy link
Contributor

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 789681e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136509%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@freakboy3742
Copy link
Contributor

How do the !buildbot pragmas work? I don't find a section the devguide https://devguide.python.org/testing/buildbots/ Maybe we should add a paragraph there explaining.

I'm not sure if the buildbot issue is a permissions thing, or if the buildbot directive has to be a comment on its own. I've asked on Discord for clarification; in the meantime, I've kicked off a build for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants