Skip to content

gh-137291: Support perf profiler with an evaluation hook #137292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025

Conversation

DinoV
Copy link
Contributor

@DinoV DinoV commented Jul 31, 2025

Adds support for perf profiling with a frame evaluator already installed. When activing the perf profiler it saves the previous frame evaluator and forwards calls to it.

@DinoV DinoV requested review from pablogsal and markshannon July 31, 2025 23:04
@pablogsal
Copy link
Member

!buildbot perf

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a376dfb 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137292%2Fmerge

The command will test the builders whose names match following regular expression: perf

The builders matched are:

  • AMD64 Arch Linux Perf PR

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR

I trigerred the perf buildbots, feel free to land if there aren't any problems there.

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a376dfb 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137292%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2025
@DinoV DinoV merged commit 375f484 into python:main Aug 7, 2025
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants