[mypyc] Add minimal, experimental librt.base64 module #20226
Merged
+327
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless experimental features are explicitly enabled, librt.base64 will be empty for now.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
p-sawicki
approved these changes
Nov 13, 2025
Collaborator
Author
|
Related issue: mypyc/mypyc#1128 (this is the first functionality in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module currently only has a
b64encodefunction adapted from CPython. It's only enabled when librt is compiled with experimental features enabled, so that we are free to iterate on this and break backward compatibility until we are ready to declare the module as stable.This also adds a way to define experimental features in
librt(and mypyc in general, but it's currently only used forlibrt).In follow-up PRs I'm planning to add a more efficient implementation of
b64encodeand add more features to the module, including decoding. I'm not planning to include every feature from the stdlib base64 module, since many of them aren't used very widely.