Skip to content

Commit 6018a32

Browse files
committed
Bump djangorestframework to 3.11.0 and django-filter to 2.2.0
1 parent 85fc30b commit 6018a32

File tree

5 files changed

+15
-12
lines changed

5 files changed

+15
-12
lines changed

junction/conferences/views.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55
from django.http.response import HttpResponseRedirect
66
from django.shortcuts import get_object_or_404
77
from django.views.decorators.http import require_http_methods
8-
from rest_framework import filters, viewsets
8+
9+
from django_filters import rest_framework as filters
10+
11+
from rest_framework import viewsets
912

1013
from .models import Conference, ConferenceVenue, Room
1114
from .serializers import ConferenceSerializer, RoomSerializer, VenueSerializer
@@ -25,7 +28,7 @@ class RoomView(viewsets.ReadOnlyModelViewSet):
2528
queryset = Room.objects.all()
2629
serializer_class = RoomSerializer
2730
filter_backend = (filters.DjangoFilterBackend,)
28-
filter_fields = ("venue",)
31+
filterset_fields = ("venue",)
2932

3033

3134
@require_http_methods(["GET"])

junction/proposals/views.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,11 @@
1212
from django.shortcuts import get_object_or_404, render
1313
from django.views.decorators.http import require_http_methods
1414
from hashids import Hashids
15-
from rest_framework import filters, viewsets
15+
from rest_framework import viewsets
1616
from rest_framework.response import Response
1717

18+
from django_filters import rest_framework as filters
19+
1820
from junction.base.constants import (
1921
ConferenceSettingConstants,
2022
ConferenceStatus,
@@ -39,7 +41,7 @@ class ProposalView(viewsets.ReadOnlyModelViewSet):
3941
queryset = Proposal.objects.filter(status=2)
4042
serializer_class = serializers.ProposalSerializer
4143
filter_backend = (filters.DjangoFilterBackend,)
42-
filter_fields = ("conference", "review_status", "proposal_type", "proposal_section")
44+
filterset_fields = ("conference", "review_status", "proposal_type", "proposal_section")
4345

4446
def get_queryset(self):
4547
data = super(ProposalView, self).get_queryset()

junction/schedule/views.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,11 @@
66
from django.http import HttpResponse
77
from django.shortcuts import Http404, render
88
from django.template.loader import render_to_string
9-
from rest_framework import filters, viewsets
9+
from rest_framework import viewsets
1010
from rest_framework.response import Response
1111

12+
from django_filters import rest_framework as filters
13+
1214
from .models import ScheduleItem
1315
from .serializers import ScheduleSerializer
1416

@@ -17,7 +19,7 @@ class ScheduleView(viewsets.ReadOnlyModelViewSet):
1719
queryset = ScheduleItem.objects.all()
1820
serializer_class = ScheduleSerializer
1921
filter_backend = (filters.DjangoFilterBackend,)
20-
filter_fields = ("room", "conference", "event_date")
22+
filterset_fields = ("room", "conference", "event_date")
2123

2224
def get_queryset(self):
2325
data = (

requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Django==1.11.17
22
celery==3.1.20
3-
djangorestframework==3.4
4-
django-filter==1.0.1
3+
djangorestframework==3.11.0
4+
django-filter==2.2.0
55

66
# Persistent Store
77
# -------------------------------------------------

settings/common.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,10 +214,6 @@
214214
# Make sure DB request held on for minimim 5 minutes
215215
CONN_MAX_AGE = 300
216216

217-
REST_FRAMEWORK = {
218-
"DEFAULT_FILTER_BACKENDS": ("rest_framework.filters.DjangoFilterBackend",)
219-
}
220-
221217
EXPLARA_API_TOKEN = "shjbalkfbdskjlbdskljbdskaljfb"
222218

223219
QR_CODES_DIR = ROOT_DIR + "/qr_files"

0 commit comments

Comments
 (0)