Switch from expecttest/assertExpectedInline to assertExpectedJournal #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
jansel
added a commit
that referenced
this pull request
Jul 6, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
This was referenced Jul 6, 2025
Merged
Merged
facebook-github-bot
added
the
CLA Signed
jansel
added a commit
that referenced
this pull request
Jul 6, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
jansel
added a commit
that referenced
this pull request
Jul 8, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
jansel
added a commit
that referenced
this pull request
Jul 8, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
jansel
added a commit
that referenced
this pull request
Jul 8, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
jansel
added a commit
that referenced
this pull request
Jul 8, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
jansel
added a commit
that referenced
this pull request
Jul 8, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
jansel
added a commit
that referenced
this pull request
Jul 8, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
jansel
added a commit
that referenced
this pull request
Jul 8, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
jansel
added a commit
that referenced
this pull request
Jul 8, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
yf225
approved these changes
Jul 8, 2025
jansel
added a commit
that referenced
this pull request
Jul 8, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
jansel
added a commit
that referenced
this pull request
Jul 8, 2025
Implements our own assertExpectedJournal that writes expected results to a separate file rather than inline. This: 1) Make test files easier to read/edit (especially for AI coding tools) 2) Fixes a race in expecttest where multiple edits to the same file errored stack-info: PR: #241, branch: jansel/stack/80
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs (oldest at bottom):
Switch from expecttest/assertExpectedInline to assertExpectedJournal
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline. This:
errored
I also (asked an AI to) add missing assertExpectedJournal calls for many tests, which is why this PR adds lines.