Skip to content

Switch from expecttest/assertExpectedInline to assertExpectedJournal #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

jansel
Copy link
Contributor

@jansel jansel commented Jul 6, 2025

Stacked PRs (oldest at bottom):


Switch from expecttest/assertExpectedInline to assertExpectedJournal

Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline. This:

  1. Make test files easier to read/edit (especially for AI coding tools)
  2. Fixes a race in expecttest where multiple edits to the same file
    errored

I also (asked an AI to) add missing assertExpectedJournal calls for many tests, which is why this PR adds lines.

Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
jansel added a commit that referenced this pull request Jul 6, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/80 branch from c25d849 to 475a096 Compare July 6, 2025 00:24
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 6, 2025
@jansel jansel changed the base branch from jansel/stack/79 to main July 6, 2025 04:03
jansel added a commit that referenced this pull request Jul 6, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/80 branch from 475a096 to c6bd89a Compare July 6, 2025 04:03
@jansel jansel changed the base branch from main to jansel/stack/79 July 6, 2025 04:04
@jansel jansel requested a review from yf225 July 8, 2025 01:44
@jansel jansel changed the base branch from jansel/stack/79 to main July 8, 2025 01:46
@jansel jansel force-pushed the jansel/stack/80 branch from c6bd89a to 209642d Compare July 8, 2025 01:46
jansel added a commit that referenced this pull request Jul 8, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel changed the base branch from main to jansel/stack/79 July 8, 2025 01:46
@jansel jansel force-pushed the jansel/stack/79 branch from 2d0cd8c to b676f66 Compare July 8, 2025 01:46
@jansel jansel force-pushed the jansel/stack/80 branch from 209642d to 2675cc8 Compare July 8, 2025 01:46
jansel added a commit that referenced this pull request Jul 8, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/79 branch from b676f66 to 850c84d Compare July 8, 2025 01:47
jansel added a commit that referenced this pull request Jul 8, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/80 branch from 2675cc8 to 2eab320 Compare July 8, 2025 01:47
@jansel jansel changed the base branch from jansel/stack/79 to main July 8, 2025 04:01
jansel added a commit that referenced this pull request Jul 8, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/80 branch from 2eab320 to be5822e Compare July 8, 2025 04:01
@jansel jansel changed the base branch from main to jansel/stack/79 July 8, 2025 04:01
@jansel jansel changed the base branch from jansel/stack/79 to main July 8, 2025 04:05
jansel added a commit that referenced this pull request Jul 8, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/80 branch from be5822e to 7701680 Compare July 8, 2025 04:05
@jansel jansel changed the base branch from main to jansel/stack/79 July 8, 2025 04:05
@jansel jansel changed the base branch from jansel/stack/79 to main July 8, 2025 04:12
jansel added a commit that referenced this pull request Jul 8, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/80 branch from 7701680 to 0bfc8d8 Compare July 8, 2025 04:13
@jansel jansel changed the base branch from main to jansel/stack/79 July 8, 2025 04:13
@jansel jansel changed the base branch from jansel/stack/79 to main July 8, 2025 04:36
jansel added a commit that referenced this pull request Jul 8, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/80 branch from 0bfc8d8 to 584e43e Compare July 8, 2025 04:36
jansel added a commit that referenced this pull request Jul 8, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/80 branch from 584e43e to bfead32 Compare July 8, 2025 04:36
@jansel jansel mentioned this pull request Jul 8, 2025
@jansel jansel changed the base branch from main to jansel/stack/79 July 8, 2025 04:36
@jansel jansel changed the base branch from jansel/stack/79 to main July 8, 2025 05:36
jansel added a commit that referenced this pull request Jul 8, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/80 branch from bfead32 to 558d2e6 Compare July 8, 2025 05:36
@jansel jansel changed the base branch from main to jansel/stack/79 July 8, 2025 05:36
@jansel jansel force-pushed the jansel/stack/79 branch from cbbff7b to d982ee2 Compare July 8, 2025 14:07
jansel added a commit that referenced this pull request Jul 8, 2025
Implements our own assertExpectedJournal that writes expected
results to a separate file rather than inline.  This:
1) Make test files easier to read/edit (especially for AI coding tools)
2) Fixes a race in expecttest where multiple edits to the same file
   errored

stack-info: PR: #241, branch: jansel/stack/80
@jansel jansel force-pushed the jansel/stack/80 branch from 558d2e6 to b6527f6 Compare July 8, 2025 14:07
@jansel jansel changed the base branch from jansel/stack/79 to main July 8, 2025 14:13
@jansel jansel force-pushed the jansel/stack/80 branch from b6527f6 to d1c2ac8 Compare July 8, 2025 14:13
@jansel jansel merged commit 902741b into main Jul 8, 2025
5 checks passed
@jansel jansel mentioned this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants