Skip to content

[BC breaking] Add MulticastTensor support to hl.signal & hl.wait (as_ptrs) #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: joydddd/stack/17
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions examples/all_gather_matmul.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ def helion_matmul_w_progress(
tile_m.begin // (M_per_rank // SPLITS_PER_RANK),
],
signal=1,
update=None,
op="ld",
scope="gpu",
sem="acquire",
)
for tile_k in hl.tile(K):
# TODO(joydddd): use a_shared and skip barrier when data is available on local rank.
Expand Down
7 changes: 7 additions & 0 deletions helion/language/multicast_tensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
from . import _decorators

if TYPE_CHECKING:
from typing import Sequence

from .._compiler.type_propagation import TypeInfo
from .._compiler.variable_origin import Origin

Expand Down Expand Up @@ -79,6 +81,11 @@ def __setitem__( # pyright ignore[reportIncompatibleMethodOverride]
) -> None:
raise exc.NotInsideKernel

def new_empty(
self, *args: Sequence[int | torch.SymInt], **kwargs: dict
) -> torch.Tensor:
return self.tensor_like.new_empty(*args, **kwargs) # pyright: ignore[reportCallIssue]


def multicast_like(
tensor_like: torch.Tensor,
Expand Down
Loading
Loading