Enable bugprone, misc and readability checks of tidy (#4488)

Summary:
Pull Request resolved: #4488

X-link: facebookresearch/FBGEMM#1540

The PR adds more clang-tidy checks and fixes most warnings in source files.

Pull Request resolved: #4479

Reviewed By: cthi

Differential Revision: D78252587

Pulled By: q10

fbshipit-source-id: 7cbbfc2c44b3e9ed3a64855cab03d601dd5ae9b7

Author: cyyever

.clang-tidy

@@ -10,19 +10,60 @@ Checks: '
 clang-analyzer*,
 clang-diagnostic-missing-prototypes,
 cppcoreguidelines-init-variables,
-bugprone-argument-comment,
-misc-use-internal-linkage,
+bugprone*,
+-bugprone-crtp-constructor-accessibility,
+-bugprone-easily-swappable-parameters,
+-bugprone-exception-escape,
+-bugprone-implicit*,
+-bugprone-macro-parentheses,
+-bugprone-narrowing-conversions,
+-bugprone-reserved-identifier,
+-bugprone-signed-char-misuse,
+-bugprone-switch-missing-default-case,
+misc-*,
+-misc-confusable-identifiers,
+-misc-const-correctness,
+-misc-include-cleaner,
+-misc-no-recursion,
+-misc-non-private-member-variables-in-classes,
+-misc-use-anonymous-namespace,
+-misc-unused-parameters,
 modernize*,
--modernize-use-auto,
--modernize-use-constraints,
--modernize-use-trailing-return-type,
 -modernize-avoid-c-arrays,
 -modernize-avoid-bind,
+-modernize-return-braced-init-list,
+-modernize-use-auto,
+-modernize-use-constraints,
 -modernize-use-designated-initializers,
--modernize-use-ranges,
--modernize-use-integer-sign-comparison
+-modernize-use-integer-sign-comparison,
 -modernize-use-nodiscard,
+-modernize-use-ranges,
+-modernize-use-trailing-return-type,
+-modernize-use-transparent-functors,
 performance*,
+-performance-enum-size,
+readability*,
+-readability-avoid-nested-conditional-operator,
+-readability-avoid-const-params-in-decls,
+-readability-avoid-unconditional-preprocessor-if,
+-readability-braces-around-statements,
+-readability-container-contains,
+-readability-convert-member-functions-to-static,
+-readability-else-after-return,
+-readability-function-cognitive-complexity,
+-readability-identifier-length,
+-readability-implicit-bool-conversion,
+-readability-isolate-declaration,
+-readability-make-member-function-const,
+-readability-magic-numbers,
+-readability-math-missing-parentheses,
+-readability-non-const-parameter,
+-readability-qualified-auto,
+-readability-uppercase-literal-suffix,
+-readability-redundant-access-specifiers,
+-readability-redundant-control-flow,
+-readability-simplify-boolean-expr,
+-readability-suspicious-call-argument,
 '
 CheckOptions:
  - key: facebook-cuda-safe-api-call-check.HandlerName

bench/BenchUtils.cc

@@ -22,13 +22,21 @@ namespace fbgemm {
 static std::default_random_engine eng;
 
 template <typename T>
-void randFill(aligned_vector<T>& vec, T low, T high, std::true_type) {
+void randFill(
+    aligned_vector<T>& vec,
+    T low,
+    T high,
+    std::true_type /*unused*/) {
   std::uniform_int_distribution<int> dis(low, high);
   std::generate(vec.begin(), vec.end(), [&] { return dis(eng); });
 }
 
 template <typename T>
-void randFill(aligned_vector<T>& vec, T low, T high, std::false_type) {
+void randFill(
+    aligned_vector<T>& vec,
+    T low,
+    T high,
+    std::false_type /*unused*/) {
   std::uniform_real_distribution<T> dis(low, high);
   std::generate(vec.begin(), vec.end(), [&] { return dis(eng); });
 }
@@ -124,7 +132,7 @@ bool parseArgumentBool(
 }
 
 #if defined(USE_MKL)
-void test_xerbla(char* srname, const int* info, int) {
+void test_xerbla(char* srname, const int* info, int /*unused*/) {
   // srname - name of the function that called xerbla
   // info - position of the invalid parameter in the parameter list
   // len - length of the name in bytes

bench/BenchUtils.h

@@ -9,6 +9,7 @@
 #pragma once
 #include <chrono>
 #include <functional>
+#include <memory>
 #include <vector>
 
 #if defined(__x86_64__) || defined(__i386__) || \

bench/EmbeddingSpMDMBenchmark.cc

@@ -408,8 +408,8 @@ int main() {
               cout << "Mean ";
             }
             cout << input_dtype << " inputs";
-            bool use_fp16_inputs = input_dtype == "fp16" ? true : false;
-            bool use_bf16_inputs = input_dtype == "fp16" ? true : false;
+            bool use_fp16_inputs = input_dtype == "fp16";
+            bool use_bf16_inputs = input_dtype == "fp16";
             cout << (use_32_bit_indices ? " 32" : " 64") << " bit indices";
             if (prefetch) {
               cout << " with prefetching";

bench/GEMMsBenchmark.cc

@@ -224,7 +224,7 @@ performance_test(const int M, const int N, const int K, const bool timebreak) {
       }
     }
     if (flush) {
-      ((volatile char*)(llc.data()))[0] = llc.data()[0] + 1;
+      ((volatile char*)(llc.data()))[0] = llc[0] + 1;
     }
     // printMatrix(matrix_op_t::NoTranspose, Bint8.data(), k, n, n, "B
     // unpacked");
@@ -312,7 +312,7 @@ performance_test(const int M, const int N, const int K, const bool timebreak) {
       }
     }
     if (flush) {
-      ((volatile char*)(llc.data()))[0] = llc.data()[0] + 1;
+      ((volatile char*)(llc.data()))[0] = llc[0] + 1;
     }
     // printMatrix(matrix_op_t::NoTranspose, Bint8.data(), k, n, n, "B
     // unpacked");

bench/GEMMsTunableBenchmark.cc

@@ -160,7 +160,7 @@ static void performance_test(
     }
   }
   if (flush) {
-    ((volatile char*)(llc.data()))[0] = llc.data()[0] + 1;
+    ((volatile char*)(llc.data()))[0] = llc[0] + 1;
   }
 
 #ifdef FBGEMM_MEASURE_TIME_BREAKDOWN

bench/GroupwiseConvRequantizeBenchmark.cc

@@ -453,7 +453,7 @@ static void performance_test() {
     }
 
     if (flush) {
-      ((volatile char*)(llc.data()))[0] = llc.data()[0] + 1;
+      ((volatile char*)(llc.data()))[0] = llc[0] + 1;
     }
 
     // packedB.printPackedMatrix("bench B Packed");

bench/Im2ColFusedRequantizeBenchmark.cc

@@ -289,7 +289,7 @@ static void performance_test() {
     }
 
     if (flush) {
-      ((volatile char*)(llc.data()))[0] = llc.data()[0] + 1;
+      ((volatile char*)(llc.data()))[0] = llc[0] + 1;
     }
 
     // packedB.printPackedMatrix("bench B Packed");

bench/PackedFloatInOutBenchmark.cc

@@ -167,7 +167,7 @@ static void performance_test() {
     ttot *= 1e9; // convert to ns
 
     if (flush) {
-      ((volatile char*)(llc.data()))[0] = llc.data()[0] + 1;
+      ((volatile char*)(llc.data()))[0] = llc[0] + 1;
     }
 
     cout << setw(6) << m << ", " << setw(6) << n << ", " << setw(6) << k
@@ -269,7 +269,7 @@ static void performance_test() {
       }
     }
     if (flush) {
-      ((volatile char*)(llc.data()))[0] = llc.data()[0] + 1;
+      ((volatile char*)(llc.data()))[0] = llc[0] + 1;
     }
     // printMatrix(matrix_op_t::NoTranspose, Bint8.data(), k, n, n, "B
     // unpacked");

bench/PackedRequantizeAcc16Benchmark.cc

@@ -160,7 +160,7 @@ static void performance_test() {
     ttot *= 1e9; // convert to ns
 
     if (flush) {
-      ((volatile char*)(llc.data()))[0] = llc.data()[0] + 1;
+      ((volatile char*)(llc.data()))[0] = llc[0] + 1;
     }
     cout << setw(16) << runType << ", " << fixed << setw(5) << setprecision(1)
          << nops / ttot << '\n';
@@ -414,7 +414,7 @@ static void performance_test() {
       }
 
       if (flush) {
-        ((volatile char*)(llc.data()))[0] = llc.data()[0] + 1;
+        ((volatile char*)(llc.data()))[0] = llc[0] + 1;
       }
       // printMatrix(matrix_op_t::NoTranspose, Bint8.data(), k, n, n, "B
       // unpacked");