Add more tidy checks and apply fixes (#4466)

Summary:
Pull Request resolved: #4466

X-link: facebookresearch/FBGEMM#1525

Almost all fixes are replacing ``std::endl`` with '\n' and replacing `std::bind` with lambdas.

Pull Request resolved: #4461

Reviewed By: cthi

Differential Revision: D78024382

Pulled By: q10

fbshipit-source-id: 27301c44878863fd628d09ff5843ddf9093ab68f

Author: cyyever

.clang-tidy

@@ -7,6 +7,8 @@ InheritParentConfig: true
 # @nolint
 Checks: '
 -*,
+clang-analyzer*,
+clang-diagnostic-missing-prototypes,
 cppcoreguidelines-init-variables,
 bugprone-argument-comment,
 misc-use-internal-linkage,
@@ -21,7 +23,6 @@ modernize*,
 -modernize-use-integer-sign-comparison
 -modernize-use-nodiscard,
 performance*,
--performance-avoid-endl
 '
 CheckOptions:
  - key: facebook-cuda-safe-api-call-check.HandlerName

src/EmbeddingSpMDM.cc

@@ -997,7 +997,7 @@ GenEmbeddingSpMDMLookup<
         }
 
         if (err) {
-          std::cout << "Error: in fn add" << std::endl;
+          std::cout << "Error: in fn add" << '\n';
           return nullptr;
         }
 

src/EmbeddingSpMDMAutovec.cc

@@ -15,7 +15,7 @@
 #include "fbgemm/FbgemmBuild.h"
 #include "fbgemm/FloatConversion.h"
 
-#include <math.h>
+#include <cmath>
 
 #include <algorithm>
 #include <array>

src/EmbeddingSpMDMNBit.cc

@@ -999,7 +999,7 @@ GenEmbeddingSpMDMNBitLookup<
           err = runtime().add(&fn, &code);
         }
         if (err) {
-          cout << "Error: in fn add" << endl;
+          cout << "Error: in fn add" << '\n';
           return nullptr;
         }
 

src/EmbeddingStatsTracker.cc

@@ -53,8 +53,7 @@ void EmbeddingStatsTracker::recordPattern(
     }
     for (const auto& pair : tables_) {
       const auto& pattern = pair.first;
-      logFile_ << pattern.toString() << "freq=" << pair.second << ";"
-               << std::endl;
+      logFile_ << pattern.toString() << "freq=" << pair.second << ";" << '\n';
     }
     logFile_.flush();
     logFile_.close();

src/Fbgemm.cc

@@ -227,29 +227,39 @@ bool fbgemmOptimizedGConv(const conv_param_t<SPATIAL_DIM>& conv_p) {
       std::all_of(
              conv_p.K.begin(),
              conv_p.K.end(),
-             std::bind(areEqual, std::placeholders::_1, 3)) &&
+             [areEqual](auto&& PH1) {
+               return areEqual(std::forward<decltype(PH1)>(PH1), 3);
+             }) &&
 
       std::all_of(
              conv_p.pad.begin(),
              conv_p.pad.end(),
-             std::bind(areEqual, std::placeholders::_1, 1)) &&
+             [areEqual](auto&& PH1) {
+               return areEqual(std::forward<decltype(PH1)>(PH1), 1);
+             }) &&
 
       std::all_of(
              conv_p.dilation.begin(),
              conv_p.dilation.end(),
-             std::bind(areEqual, std::placeholders::_1, 1)) &&
+             [areEqual](auto&& PH1) {
+               return areEqual(std::forward<decltype(PH1)>(PH1), 1);
+             }) &&
 
       // Height/Width strides should be the same and
       // should be either 1 or 2
       // Temporal stride can be anything.
       (std::all_of(
            conv_p.stride.begin() + SPATIAL_DIM - 2,
            conv_p.stride.end(),
-           std::bind(areEqual, std::placeholders::_1, 1)) ||
+           [areEqual](auto&& PH1) {
+             return areEqual(std::forward<decltype(PH1)>(PH1), 1);
+           }) ||
        std::all_of(
            conv_p.stride.begin() + SPATIAL_DIM - 2,
            conv_p.stride.end(),
-           std::bind(areEqual, std::placeholders::_1, 2))) &&
+           [areEqual](auto&& PH1) {
+             return areEqual(std::forward<decltype(PH1)>(PH1), 2);
+           })) &&
       !conv_p.transposed;
 }
 

src/FbgemmI64.cc

@@ -382,7 +382,7 @@ CodeGenBase<int64_t, int64_t, int64_t, int64_t>::getOrCreate(
       err = runtime().add(&fn, &code);
     }
     if (err) {
-      cout << "Error: in fn add" << endl;
+      cout << "Error: in fn add" << '\n';
       return nullptr;
     }
 

src/GenerateI8Depthwise.cc

@@ -564,7 +564,7 @@ GenI8Depthwise::jit_kernel_signature GenI8Depthwise::getOrCreate(
       err = runtime().add(&fn, &code);
     }
     if (err) {
-      std::cout << "Error: in fn add" << std::endl;
+      std::cout << "Error: in fn add" << '\n';
       return nullptr;
     }
 

src/GenerateKernelDirectConvU8S8S32ACC32.cc

@@ -408,7 +408,7 @@ DirectConvCodeGenBase<uint8_t, int8_t, int32_t, int32_t>::getOrCreateDirectConv(
       err = runtime().add(&fn, &code);
     }
     if (err) {
-      std::cout << "Error: in fn add" << std::endl;
+      std::cout << "Error: in fn add" << '\n';
       return nullptr;
     }
 
@@ -777,7 +777,7 @@ DirectConvCodeGenBase<uint8_t, int8_t, int32_t, int32_t>::
       err = runtime().add(&fn, &code);
     }
     if (err) {
-      std::cout << "Error: in fn add" << std::endl;
+      std::cout << "Error: in fn add" << '\n';
       return nullptr;
     }
 

src/GenerateKernelU8S8S32ACC16.cc

@@ -329,7 +329,7 @@ CodeGenBase<uint8_t, int8_t, int32_t, int16_t>::getOrCreate<inst_set_t::avx2>(
       err = runtime().add(&fn, &code);
     }
     if (err) {
-      std::cout << "Error: in fn add" << std::endl;
+      std::cout << "Error: in fn add" << '\n';
       return nullptr;
     }