Support prefetch pipeline in bounds_check_indices #4312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D72365505 |
|
This pull request was exported from Phabricator. Differential Revision: D72365505 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Jun 16, 2025
Summary: Pull Request resolved: pytorch#4312 X-link: facebookresearch/FBGEMM#1174 Frontend of D72343128 This diff reduces the grid dimension of the bounds_check_indices kernel when pipeline prefetching is used (in embedding memory offloading). We need to use the v2 kernel since v1 does not support grid dimension reduction. Reviewed By: jwfromm Differential Revision: D72365505
|
This pull request was exported from Phabricator. Differential Revision: D72365505 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Jun 16, 2025
Summary: Pull Request resolved: pytorch#4312 X-link: facebookresearch/FBGEMM#1174 Frontend of D72343128 This diff reduces the grid dimension of the bounds_check_indices kernel when pipeline prefetching is used (in embedding memory offloading). We need to use the v2 kernel since v1 does not support grid dimension reduction. Reviewed By: jwfromm Differential Revision: D72365505
Summary: Pull Request resolved: pytorch#4312 X-link: facebookresearch/FBGEMM#1174 Frontend of D72343128 This diff reduces the grid dimension of the bounds_check_indices kernel when pipeline prefetching is used (in embedding memory offloading). We need to use the v2 kernel since v1 does not support grid dimension reduction. Reviewed By: jwfromm Differential Revision: D72365505
|
This pull request was exported from Phabricator. Differential Revision: D72365505 |
|
This pull request has been merged in 9bd0892. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1174
Frontend of D72343128
This diff reduces the grid dimension of the bounds_check_indices
kernel when pipeline prefetching is used (in embedding memory
offloading). We need to use the v2 kernel since v1 does not support
grid dimension reduction.
Reviewed By: jwfromm
Differential Revision: D72365505