Enable left mask in Cutlass kernels #4799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D81295090 |
Summary: X-link: facebookresearch/FBGEMM#1820 Before this diff, we use the input stride as the output stride. However, they can be different as the input can be non-contiguous while the output is always contiguous. This diff computes the output stride separately. Reviewed By: henrylhtsang Differential Revision: D81275032
Summary: X-link: facebookresearch/FBGEMM#1823 Enable Q-left mask support in Blackwell Cutlass attention Masks: - LowerTriangularMask - BlockDiagonalCausalMask - BlockDiagonalMask Reviewed By: Aya-ZIbra, henrylhtsang Differential Revision: D81295090
sryap
force-pushed
the
export-D81295090
branch
from
80c07e0 to
371a3f4
Compare
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Aug 31, 2025
Summary: X-link: facebookresearch/FBGEMM#1823 Enable Q-left mask support in Blackwell Cutlass attention Masks: - LowerTriangularMask - BlockDiagonalCausalMask - BlockDiagonalMask Reviewed By: Aya-ZIbra, henrylhtsang Differential Revision: D81295090
sryap
force-pushed
the
export-D81295090
branch
from
371a3f4 to
c2086a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81295090 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Aug 31, 2025
Summary: X-link: facebookresearch/FBGEMM#1823 Enable Q-left mask support in Blackwell Cutlass attention Masks: - LowerTriangularMask - BlockDiagonalCausalMask - BlockDiagonalMask Reviewed By: Aya-ZIbra, henrylhtsang Differential Revision: D81295090
|
This pull request has been merged in 20237c0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enable Q-left mask support in Blackwell Cutlass attention
Masks:
Reviewed By: Aya-ZIbra, henrylhtsang
Differential Revision: D81295090