add direct_write_embedding method #4800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookresearch/FBGEMM#1824 This method will write the input embedding directly without through optimizer Reviewed By: q10 Differential Revision: D79290124
|
This pull request was exported from Phabricator. Differential Revision: D79290124 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
emlin
added a commit
to emlin/torchrec
that referenced
this pull request
Aug 31, 2025
Summary: X-link: pytorch/FBGEMM#4800 X-link: facebookresearch/FBGEMM#1824 This method will write the input embedding directly without through optimizer Reviewed By: q10 Differential Revision: D79290124
|
This pull request has been merged in 782bc1b. |
facebook-github-bot
pushed a commit
to meta-pytorch/torchrec
that referenced
this pull request
Aug 31, 2025
Summary: Pull Request resolved: #3332 X-link: pytorch/FBGEMM#4800 X-link: facebookresearch/FBGEMM#1824 This method will write the input embedding directly without through optimizer Reviewed By: q10 Differential Revision: D79290124 fbshipit-source-id: 92ffae4cfdce0086dcbecb39b7e672757c27f8af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1824
This method will write the input embedding directly without through optimizer
Reviewed By: q10
Differential Revision: D79290124