- Clean torch.check #4871
Open
- Clean torch.check #4871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@flaviotruzzi has exported this pull request. If you are a Meta employee, you can view the originating diff in D82347053. |
Summary: torch._check expects a string, however this was passing a lambda function that returned a string, which was causing a issues when compiling the code with PT2. Just cleaned it up to use f-string. Reviewed By: spcyppt Differential Revision: D82347053
flaviotruzzi
force-pushed
the
export-D82347053
branch
from
eef0702 to
c46bd47
Compare
|
@flaviotruzzi has exported this pull request. If you are a Meta employee, you can view the originating diff in D82347053. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
torch._check expects a string, however this was passing a lambda function that returned a string, which was causing a issues when compiling the code with PT2.
Just cleaned it up to use f-string.
Differential Revision: D82347053