Fix ROCm build I broke #4902
Closed
Fix ROCm build I broke #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No ciflow labels are configured for this repo. |
Summary: Broke the ROCm build by accident in D82855103 :(. Since the function is cuda specific, we can just only include it when being used for cuda for now. For some reason it cannot build properly standalone still in fbcode, which Is why I originally tried to move it to inline header, but that broke OSS since hipify would not get run. Differential Revision: D82895451
cthi
force-pushed
the
export-D82895451
branch
from
9aeb21f to
a067851
Compare
|
This pull request has been merged in 3cefe05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Broke the ROCm build by accident in D82855103 :(.
Since the function is cuda specific, we can just only include it when being used for cuda for now. For some reason it cannot build properly standalone still in fbcode, which Is why I originally tried to move it to inline header, but that broke OSS since hipify would not get run.
Differential Revision: D82895451