From f751ad4783d6c5134e9ce28768f20f27f34a26ba Mon Sep 17 00:00:00 2001 From: Yuanyuan Chen Date: Sun, 21 Sep 2025 21:51:53 +0800 Subject: [PATCH] Cleanup MSVC arguments in defs.bzl Signed-off-by: Yuanyuan Chen --- CMakeLists.txt | 4 ++-- defs.bzl | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 87d730c9d8..eb4b468de4 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -225,7 +225,7 @@ if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64|i386|i686") message(STATUS "Processor is ${CMAKE_SYSTEM_PROCESSOR}; will build AVX2 target") - get_filelist("get_fbgemm_avx2_srcs(msvc=${MSVC_BOOL})" FBGEMM_AVX2_SRCS) + get_filelist("get_fbgemm_avx2_srcs()" FBGEMM_AVX2_SRCS) get_filelist("get_fbgemm_inline_avx2_srcs(msvc=${MSVC_BOOL})" FBGEMM_AVX2_INLINE_SRCS) cpp_library( @@ -259,7 +259,7 @@ endif() if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64|i386|i686" AND CXX_AVX512_FOUND) message(STATUS "Processor is ${CMAKE_SYSTEM_PROCESSOR}; will build AVX512 target") - get_filelist("get_fbgemm_avx512_srcs(msvc=${MSVC_BOOL})" FBGEMM_AVX512_SRCS) + get_filelist("get_fbgemm_avx512_srcs()" FBGEMM_AVX512_SRCS) get_filelist("get_fbgemm_inline_avx512_srcs(msvc=${MSVC_BOOL})" FBGEMM_AVX512_INLINE_SRCS) cpp_library( diff --git a/defs.bzl b/defs.bzl index b8b59e6301..5b3d15d34a 100644 --- a/defs.bzl +++ b/defs.bzl @@ -116,8 +116,7 @@ def get_fbgemm_public_headers(): "include/fbgemm/Types.h", ] -# buildifier: disable=unused-variable -def get_fbgemm_avx2_srcs(msvc = False): +def get_fbgemm_avx2_srcs(): return [ #All the source files that either use avx2 instructions statically "src/EmbeddingSpMDMAvx2.cc", @@ -151,8 +150,7 @@ def get_fbgemm_inline_avx2_srcs(msvc = False, buck = False): }) return asm_srcs if not msvc else intrinsics_srcs -# buildifier: disable=unused-variable -def get_fbgemm_avx512_srcs(msvc = False): +def get_fbgemm_avx512_srcs(): return [ #All the source files that use avx512 instructions statically "src/FbgemmBfloat16ConvertAvx512.cc",