Skip to content

Cleanup MSVC arguments in defs.bzl #4903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Cleanup MSVC arguments in defs.bzl #4903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64|i386|i686")

message(STATUS "Processor is ${CMAKE_SYSTEM_PROCESSOR}; will build AVX2 target")

get_filelist("get_fbgemm_avx2_srcs(msvc=${MSVC_BOOL})" FBGEMM_AVX2_SRCS)
get_filelist("get_fbgemm_avx2_srcs()" FBGEMM_AVX2_SRCS)
get_filelist("get_fbgemm_inline_avx2_srcs(msvc=${MSVC_BOOL})" FBGEMM_AVX2_INLINE_SRCS)

cpp_library(
Expand Down Expand Up @@ -259,7 +259,7 @@ endif()
if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64|i386|i686" AND CXX_AVX512_FOUND)
message(STATUS "Processor is ${CMAKE_SYSTEM_PROCESSOR}; will build AVX512 target")

get_filelist("get_fbgemm_avx512_srcs(msvc=${MSVC_BOOL})" FBGEMM_AVX512_SRCS)
get_filelist("get_fbgemm_avx512_srcs()" FBGEMM_AVX512_SRCS)
get_filelist("get_fbgemm_inline_avx512_srcs(msvc=${MSVC_BOOL})" FBGEMM_AVX512_INLINE_SRCS)

cpp_library(
Expand Down
6 changes: 2 additions & 4 deletions defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@ def get_fbgemm_public_headers():
"include/fbgemm/Types.h",
]

# buildifier: disable=unused-variable
def get_fbgemm_avx2_srcs(msvc = False):
def get_fbgemm_avx2_srcs():
return [
#All the source files that either use avx2 instructions statically
"src/EmbeddingSpMDMAvx2.cc",
Expand Down Expand Up @@ -151,8 +150,7 @@ def get_fbgemm_inline_avx2_srcs(msvc = False, buck = False):
})
return asm_srcs if not msvc else intrinsics_srcs

# buildifier: disable=unused-variable
def get_fbgemm_avx512_srcs(msvc = False):
def get_fbgemm_avx512_srcs():
return [
#All the source files that use avx512 instructions statically
"src/FbgemmBfloat16ConvertAvx512.cc",
Expand Down
Loading