Use armv8.2-a+fp16fml #4942
Closed
Use armv8.2-a+fp16fml #4942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
Summary: X-link: facebookresearch/FBGEMM#1977 Add a missing part in #4942 . I also fix another aarch64 issue on PyTorch CI: ``` /var/lib/jenkins/workspace/third_party/fbgemm/include/fbgemm/./Utils.h:26:10: fatal error: arm_neon_sve_bridge.h: No such file or directory 26 | #include <arm_neon_sve_bridge.h> // manual | ^~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. ``` [ARM documentation](https://developer.arm.com/documentation/110065/0100/Software-codec-optimization/Compiler-recommendations) says: SVE and SVE2 feature paths in libaom, libvpx, and x265 require the intrinsics declared in arm_neon_sve_bridge.h. This header file is available in the following releases: Clang 17 and later. GCC 14 and later. Pull Request resolved: #4948 Reviewed By: cthi Differential Revision: D83578552 Pulled By: q10 fbshipit-source-id: 13b07cbb68ec7b233488a1958d86510b8828a52f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the GCC documentation, the march armv8-a+fp16fml is invalid. A build failure was observed on PyTorch CI.
FYI
but
