Revert to debug flag

cehongwang · cehongwang · commit 2fff7adf078b · 2025-06-03T19:38:29.000Z
diff --git a/py/torch_tensorrt/dynamo/Debugger.py b/py/torch_tensorrt/dynamo/Debugger.py
@@ -14,67 +14,60 @@
 GRAPH_LEVEL = 5
 logging.addLevelName(GRAPH_LEVEL, "GRAPHS")
 
-# Debugger States
-DEBUG_FILE_DIR = tempfile.TemporaryDirectory().name
-SAVE_ENGINE_PROFILE = False
-
 
 class Debugger:
     def __init__(
         self,
-        level: str,
+        log_level: str,
         capture_fx_graph_before: Optional[List[str]] = None,
         capture_fx_graph_after: Optional[List[str]] = None,
         save_engine_profile: bool = False,
         logging_dir: Optional[str] = None,
     ):
-
-        if level != "graphs" and (capture_fx_graph_after or save_engine_profile):
+        self.debug_file_dir = tempfile.TemporaryDirectory().name
+        if log_level != "graphs" and (capture_fx_graph_after or save_engine_profile):
             _LOGGER.warning(
                 "Capture FX Graph or Draw Engine Graph is only supported when level is 'graphs'"
             )
 
-        if level == "debug":
-            self.level = logging.DEBUG
-        elif level == "info":
-            self.level = logging.INFO
-        elif level == "warning":
-            self.level = logging.WARNING
-        elif level == "error":
-            self.level = logging.ERROR
-        elif level == "internal_errors":
-            self.level = logging.CRITICAL
-        elif level == "graphs":
-            self.level = GRAPH_LEVEL
+        if log_level == "debug":
+            self.log_level = logging.DEBUG
+        elif log_level == "info":
+            self.log_level = logging.INFO
+        elif log_level == "warning":
+            self.log_level = logging.WARNING
+        elif log_level == "error":
+            self.log_level = logging.ERROR
+        elif log_level == "internal_errors":
+            self.log_level = logging.CRITICAL
+        elif log_level == "graphs":
+            self.log_level = GRAPH_LEVEL
 
         else:
             raise ValueError(
-                f"Invalid level: {level}, allowed levels are: debug, info, warning, error, internal_errors, graphs"
+                f"Invalid level: {log_level}, allowed levels are: debug, info, warning, error, internal_errors, graphs"
             )
 
         self.capture_fx_graph_before = capture_fx_graph_before
         self.capture_fx_graph_after = capture_fx_graph_after
-        global SAVE_ENGINE_PROFILE
-        SAVE_ENGINE_PROFILE = save_engine_profile
 
         if logging_dir is not None:
-            global DEBUG_FILE_DIR
-            DEBUG_FILE_DIR = logging_dir
-        os.makedirs(DEBUG_FILE_DIR, exist_ok=True)
+            self.debug_file_dir = logging_dir
+        os.makedirs(self.debug_file_dir, exist_ok=True)
 
     def __enter__(self) -> None:
         self.original_lvl = _LOGGER.getEffectiveLevel()
         self.rt_level = torch.ops.tensorrt.get_logging_level()
         dictConfig(self.get_config())
 
-        if self.level == GRAPH_LEVEL:
+        if self.log_level == GRAPH_LEVEL:
             self.old_pre_passes, self.old_post_passes = (
                 ATEN_PRE_LOWERING_PASSES.passes,
                 ATEN_POST_LOWERING_PASSES.passes,
             )
             pre_pass_names = [p.__name__ for p in self.old_pre_passes]
             post_pass_names = [p.__name__ for p in self.old_post_passes]
-            path = os.path.join(DEBUG_FILE_DIR, "lowering_passes_visualization")
+            path = os.path.join(self.debug_file_dir, "lowering_passes_visualization")
             if self.capture_fx_graph_before is not None:
                 pre_vis_passes = [
                     p for p in self.capture_fx_graph_before if p in pre_pass_names
@@ -100,11 +93,12 @@ def __exit__(self, exc_type: Any, exc_value: Any, exc_tb: Any) -> None:
 
         dictConfig(self.get_default_config())
         torch.ops.tensorrt.set_logging_level(self.rt_level)
-        if self.level == GRAPH_LEVEL and self.capture_fx_graph_after:
+        if self.log_level == GRAPH_LEVEL and self.capture_fx_graph_after:
             ATEN_PRE_LOWERING_PASSES.passes, ATEN_POST_LOWERING_PASSES.passes = (
                 self.old_pre_passes,
                 self.old_post_passes,
             )
+        self.debug_file_dir = tempfile.TemporaryDirectory().name
 
     def get_config(self) -> dict[str, Any]:
         config = {
@@ -122,21 +116,21 @@ def get_config(self) -> dict[str, Any]:
             },
             "handlers": {
                 "file": {
-                    "level": self.level,
+                    "level": self.log_level,
                     "class": "logging.FileHandler",
-                    "filename": f"{DEBUG_FILE_DIR}/torch_tensorrt_logging.log",
+                    "filename": f"{self.debug_file_dir}/torch_tensorrt_logging.log",
                     "formatter": "standard",
                 },
                 "console": {
-                    "level": self.level,
+                    "level": self.log_level,
                     "class": "logging.StreamHandler",
                     "formatter": "brief",
                 },
             },
             "loggers": {
                 "": {  # root logger
                     "handlers": ["file", "console"],
-                    "level": self.level,
+                    "level": self.log_level,
                     "propagate": True,
                 },
             },
diff --git a/py/torch_tensorrt/dynamo/_compiler.py b/py/torch_tensorrt/dynamo/_compiler.py
@@ -2,7 +2,6 @@
 
 import collections.abc
 import logging
-import os
 import platform
 import warnings
 from typing import Any, Collection, List, Optional, Sequence, Set, Tuple, Union
@@ -504,14 +503,6 @@ def compile(
         torch.fx.GraphModule: Compiled FX Module, when run it will execute via TensorRT
     """
 
-    if debug:
-        warnings.warn(
-            "The 'debug' argument is deprecated and will be removed in a future release. "
-            "Please use the torch_tensorrt.dynamo.Debugger context manager for debugging and graph capture.",
-            DeprecationWarning,
-            stacklevel=2,
-        )
-
     if "truncate_long_and_double" in kwargs.keys():
         if truncate_double is not _defaults.TRUNCATE_DOUBLE:
             raise ValueError(
@@ -642,6 +633,7 @@ def compile(
         "enabled_precisions": (
             enabled_precisions if enabled_precisions else _defaults.ENABLED_PRECISIONS
         ),
+        "debug": debug,
         "device": device,
         "assume_dynamic_shape_support": assume_dynamic_shape_support,
         "workspace_size": workspace_size,
@@ -907,23 +899,6 @@ def contains_metadata(gm: torch.fx.GraphModule) -> bool:
             )
 
             trt_modules[name] = trt_module
-            from torch_tensorrt.dynamo._debugger import (
-                DEBUG_FILE_DIR,
-                SAVE_ENGINE_PROFILE,
-            )
-
-            if SAVE_ENGINE_PROFILE:
-                if settings.use_python_runtime:
-                    logger.warning(
-                        "Profiling can only be enabled when using the C++ runtime"
-                    )
-                else:
-                    path = os.path.join(DEBUG_FILE_DIR, "engine_visualization")
-                    os.makedirs(path, exist_ok=True)
-                    trt_module.enable_profiling(
-                        profiling_results_dir=path,
-                        profile_format="trex",
-                    )
 
     # Parse the graph I/O and store it in dryrun tracker
     parse_graph_io(gm, dryrun_tracker)
diff --git a/py/torch_tensorrt/dynamo/_settings.py b/py/torch_tensorrt/dynamo/_settings.py
@@ -1,4 +1,3 @@
-import logging
 from dataclasses import dataclass, field
 from typing import Collection, Optional, Set, Tuple, Union
 
@@ -8,6 +7,7 @@
 from torch_tensorrt.dynamo._defaults import (
     ASSUME_DYNAMIC_SHAPE_SUPPORT,
     CACHE_BUILT_ENGINES,
+    DEBUG,
     DISABLE_TF32,
     DLA_GLOBAL_DRAM_SIZE,
     DLA_LOCAL_DRAM_SIZE,
@@ -100,7 +100,7 @@ class CompilationSettings:
     """
 
     enabled_precisions: Set[dtype] = field(default_factory=lambda: ENABLED_PRECISIONS)
-    debug: bool = logging.root.manager.root.level <= logging.DEBUG
+    debug: bool = DEBUG
     workspace_size: int = WORKSPACE_SIZE
     min_block_size: int = MIN_BLOCK_SIZE
     torch_executed_ops: Collection[Target] = field(default_factory=set)
