-
Notifications
You must be signed in to change notification settings - Fork 365
fix: remove TRT version restriction #3435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should modify the future trt jobs to edit this restriction itself instead of changing the version in main since its basically allowing people to install unverified builds
yeah, I just wanted to have a quick try but it seems even we remove the restriction it's going to install the latest TRT. |
3130d37
to
9621a44
Compare
09d5e0a
to
f4e91be
Compare
52f9ca7
to
04c4d94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
It seems due to the tensorrt version restriction (now it's tensorrt-cu12>=10.8.0,<10.9.0) in the pyproject file, which made all tests install the same TRT.
Fixes #3434
Type of change
Checklist: