Skip to content

Improve tiling params to speed up prefill #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve tiling params to speed up prefill #2406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion torchao/experimental/ops/linear_8bit_act_xbit_weight/linear_8bit_act_xbit_weight.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,8 @@ void linear_operator(
nc = tiling_params->nc;
} else {
auto params = LinearTilingParams::from_target_tiles_per_thread(
m,
// We process m sequentially, so m_step is the "m" for the purpose of computing tiling params
Copy link
Contributor

@digantdesai digantdesai Jun 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed at the calculations, this would not chance params.mc but would make params.nc smaller and improving the caching thus improving perf?

m_step,
m_step,
n,
n_step,
Expand Down
Loading