Fix regex escape characters in documentation#4363
Conversation
Fix for vllm vllm /home/tore/.venvs/comfy/lib/python3.12/site-packages/torchao/quantization/quant_api.py:1501: SyntaxWarning: invalid escape sequence '\.' """Configuration class for applying different quantization configs to modules or parameters based on their fully qualified names (FQNs).
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4363
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New FailuresAs of commit 30e1ed4 with merge base 28e6aca ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This PR fixes Python SyntaxWarning caused by invalid escape sequences in docstring regex examples. |
|
@claude review |
|
Claude finished @andrewor14's task in 52s —— View job Code Review: Fix regex escape characters in documentation
LGTM ✅ This is a correct and straightforward fix. The docstring at Details:
One minor note: On line 1515, the trailing |
| * fully qualified parameter name, e.g. `language.layers.0.q_proj.weight` | ||
| * fully qualified module name, e.g. `language.layers.0.q_proj` | ||
| * regex for parameter names, must start with `re:`, e.g. `re:language\.layers\..+\.q_proj.weight`. | ||
| * regex for parameter names, must start with `re:`, e.g. `re:language\\.layers\\..+\\.q_proj.weight`. |
There was a problem hiding this comment.
I feel the fix should be add a r in L1501 before """?
Fix for vllm
error:
vllm
/home/tore/.venvs/comfy/lib/python3.12/site-packages/torchao/quantization/quant_api.py:1501: SyntaxWarning: invalid escape sequence '.'
"""Configuration class for applying different quantization configs to modules or parameters based on their fully qualified names (FQNs).