[mxfp8 moe training] add support for bias parm in _to_mxfp8_then_scaled_grouped_mm#4386
Open
danielvegamyhre wants to merge 3 commits into
Open
[mxfp8 moe training] add support for bias parm in _to_mxfp8_then_scaled_grouped_mm#4386danielvegamyhre wants to merge 3 commits into
danielvegamyhre wants to merge 3 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4386
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 7 New FailuresAs of commit 1a8a442 with merge base 6529fca ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4341
Summary
torch.nn.functional.scaled_grouped_mmapi supports abiasparameter, that the privatetorch._scaled_grouped_mmapi does not support._to_mxfp8_then_scaled_grouped_mmbefore the public scaled_grouped_mm api existed, so it doesn't support bias.scaled_grouped_mmapi are now reporting issues due to the param mismatch: MXFP8 MoE Training: Bias parameter mismatch between PyTorch's grouped_mm and TorchAO's _quantize_then_scaled_grouped_mm causes unexpected keyword argument error #4341