Skip to content

Commit 00e84ff

Browse files
docusaurus-botfacebook-github-bot
authored andcommitted
Fix typo in tutorials ignorelist; add SASBO and scalable_constrained_bo to ignorelist because they are timing out (#1590)
Summary: ## Motivation - Typo in #1588 - scalable_constrained_bo timing out and causing a failure since Nighly Cron 708 (2 weeks ago) or earlier - saasbo timing out and causing a failure at least some of the time since Nighly Cron 706 (2 weeks ago) or earlier ### Have you read the [Contributing Guidelines on pull requests](https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)? Yes Pull Request resolved: #1590 Test Plan: Temporarily trigger actions to run tutorials without smoke test on PR so that we can confirm they will pass now ## Related PRs #1588 Reviewed By: danielrjiang Differential Revision: D42229296 Pulled By: esantorella fbshipit-source-id: a77ca37bb13b4a4f3818e7a1276fa7683fa16f26
1 parent cbd5002 commit 00e84ff

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

scripts/build_and_verify_conda_package.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
# Get version number (created dynamically via setuptools-scm)
88
BOTORCH_VERSION=$(python -m setuptools_scm)
99
if [[ $? != "0" ]]; then
10-
echo "Determininig version via setuptools_scm failed."
10+
echo "Determining version via setuptools_scm failed."
1111
echo "Make sure that setuptools_scm is installed in your python environment."
1212
exit 1
1313
fi

scripts/run_tutorials.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@
2525
"preference_bo.ipynb", # failing. Fix planned
2626
# Causing the tutorials to crash when run without smoke test. Likely OOM.
2727
# Fix planned.
28-
"constraint_active_search",
28+
"constraint_active_search.ipynb",
29+
# Timing out
30+
"saasbo.ipynb",
31+
# Timing out
32+
"scalable_constrained_bo.ipynb",
2933
}
3034
IGNORE_SMOKE_TEST_ONLY = { # only used in smoke tests
3135
"thompson_sampling.ipynb", # very slow without KeOps + GPU

0 commit comments

Comments
 (0)