Skip to content

Commit 19daa34

Browse files
Balandatfacebook-github-bot
authored andcommitted
Fix conda build workflow and script (#1295)
Summary: This broke due to the changes in #1292. Pull Request resolved: #1295 Reviewed By: saitcakmak Differential Revision: D37735815 Pulled By: Balandat fbshipit-source-id: 359820fc20efdd8abeea0cdbd9be4a595db76dcb
1 parent eb6f2ec commit 19daa34

File tree

9 files changed

+18
-14
lines changed

9 files changed

+18
-14
lines changed

.conda/build_conda.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@
44
# This source code is licensed under the MIT license found in the
55
# LICENSE file in the root directory of this source tree.
66

7-
BOTORCH_VERSION="$(python ../setup.py --version)"
7+
# we cannot use relative paths here, since setuptools_scm options in
8+
# pyproject.toml cannot dynamically determine the root dir
9+
cd .. || exit
10+
BOTORCH_VERSION="$(python setup.py --version)"
811
export BOTORCH_VERSION
12+
cd .conda || exit
913

1014
conda build .

.conda/meta.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ requirements:
2020
- pytorch >=1.9
2121
- gpytorch >=1.6
2222
- scipy
23-
- pyro-ppl 1.8.0
23+
- pyro-ppl >=1.8.0
2424

2525
test:
2626
imports:

.github/workflows/deploy_on_release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
conda install -y scipy sphinx pytest flake8
8787
conda install -y -c gpytorch gpytorch
8888
conda install -y conda-build anaconda-client
89-
conda install -y -c conda-forge pyro-ppl==1.8.0
89+
conda install -y -c conda-forge pyro-ppl>=1.8.0
9090
conda config --set anaconda_upload no
9191
- name: Build and verify conda package
9292
shell: bash -l {0}

.github/workflows/nightly.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,13 @@ jobs:
9191
run: git fetch --prune --unshallow
9292
- name: Install dependencies
9393
shell: bash -l {0}
94-
# Don't need deps for conda build, but need them for testing
94+
# Don't need most deps for conda build, but need them for testing
95+
# We do need setuptools_scm though to properly parse the version
9596
run: |
96-
conda install -y conda-build
97+
conda install -y scipy setuptools_scm conda-build conda-verify
9798
conda config --set anaconda_upload no
9899
conda install -y -c pytorch-nightly pytorch cpuonly
99-
conda install -y scipy
100-
conda install -y -c conda-forge pyro-ppl==1.8.0
100+
conda install -y -c conda-forge pyro-ppl>=1.8.0
101101
pip install git+https://github.com/cornellius-gp/gpytorch.git
102102
- name: Build and verify conda package
103103
shell: bash -l {0}

.github/workflows/test_stable.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
conda install -y -c pytorch pytorch cpuonly
4949
conda install -y pip scipy pytest
5050
conda install -y -c gpytorch gpytorch
51-
conda install -y -c conda-forge pyro-ppl==1.8.0
51+
conda install -y -c conda-forge pyro-ppl>=1.8.0
5252
pip install .[test]
5353
- name: Unit tests
5454
shell: bash -l {0}

docs/getting_started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Before jumping the gun, we recommend you start with the high-level
1818
- gpytorch >= 1.6
1919
- scipy
2020
- multiple-dispatch
21-
- pyro-ppl == 1.8.0
21+
- pyro-ppl >= 1.8.0
2222

2323
BoTorch is easily installed via
2424
[Anaconda](https://www.anaconda.com/distribution/#download-section) (recommended)

environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ dependencies:
77
- pytorch>=1.9
88
- gpytorch>=1.6
99
- scipy
10-
- pyro-ppl=1.8.0
10+
- pyro-ppl>=1.8.0

scripts/build_and_verify_conda_package.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
# This source code is licensed under the MIT license found in the
55
# LICENSE file in the root directory of this source tree.
66

7-
cd .conda || exit
8-
97
# Get version number (created dynamically via setuptools-scm)
10-
BOTORCH_VERSION=$(python ../setup.py --version)
8+
BOTORCH_VERSION=$(python setup.py --version)
119
# Export env var (this is used in .conda/meta.yaml)
1210
export BOTORCH_VERSION
1311

12+
cd .conda || exit
13+
1414
# build package
1515
cur_dir="$(pwd)"
1616
build_dir="${cur_dir}/conda_build"

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
"gpytorch>=1.6",
8686
"scipy",
8787
"multipledispatch",
88-
"pyro-ppl==1.8.0",
88+
"pyro-ppl>=1.8.0",
8989
],
9090
extras_require={
9191
"dev": DEV_REQUIRES,

0 commit comments

Comments
 (0)