Skip to content

Commit 21ed85b

Browse files
Balandatfacebook-github-bot
authored andcommitted
Fix issue introdued in nightly flow in #1292 (#1294)
Summary: It appears that the env var was set but not sourced in the same step, which resulted in the build using a wrong version name. Pull Request resolved: #1294 Reviewed By: saitcakmak Differential Revision: D37724913 Pulled By: Balandat fbshipit-source-id: 33f47249d4a79a1b62713df1cb047dbc0bf6f6ed
1 parent 27f4c0c commit 21ed85b

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/nightly.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,17 @@ jobs:
5454
pip install git+https://github.com/cornellius-gp/gpytorch.git
5555
pip install .[test]
5656
pip install --upgrade setuptools setuptools_scm wheel
57-
- name: Build packages (wheel and source distribution)
57+
- name: Extract reduced version and save to env var
58+
# strip the commit hash from the version to enable upload to pypi
59+
# env var will persist for subsequent steps
5860
run: |
59-
# set a pseudo version that strips the commit hash to enable upload to pypi
6061
no_local_version=$(python -m setuptools_scm | cut -d "+" -f 1)
6162
echo "SETUPTOOLS_SCM_PRETEND_VERSION=${no_local_version}" >> $GITHUB_ENV
63+
- name: Build packages (wheel and source distribution)
64+
run: |
6265
python setup.py sdist bdist_wheel
6366
- name: Verify packages
6467
run: |
65-
# env var SETUPTOOLS_SCM_PRETEND_VERSION persists from previous step
6668
./scripts/build_and_verify_py_packages.sh
6769
- name: Deploy to Test PyPI
6870
uses: pypa/gh-action-pypi-publish@master

0 commit comments

Comments
 (0)