Skip to content

Commit 326b604

Browse files
sdaultonfacebook-github-bot
authored andcommitted
prune baseline points in qLogNEI by default (#2762)
Summary: X-link: facebookresearch/aepsych#666 Pull Request resolved: #2762 See title Reviewed By: SebastianAment Differential Revision: D70665739 fbshipit-source-id: 46bf660ea3448887a8210723cd68bdee04065cdd
1 parent a79b050 commit 326b604

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

botorch/acquisition/logei.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ def __init__(
273273
constraints: list[Callable[[Tensor], Tensor]] | None = None,
274274
eta: Tensor | float = 1e-3,
275275
fat: bool = True,
276-
prune_baseline: bool = False,
276+
prune_baseline: bool = True,
277277
cache_root: bool = True,
278278
tau_max: float = TAU_MAX,
279279
tau_relu: float = TAU_RELU,

test/optim/test_optimize_mixed.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,9 @@ def test_optimize_acqf_mixed_binary_only(self) -> None:
479479
# get multiple candidates
480480
root = torch.zeros(dim, device=self.device)
481481
model = QuadraticDeterministicModel(root)
482-
acqf = qLogNoisyExpectedImprovement(model=model, X_baseline=train_X)
482+
acqf = qLogNoisyExpectedImprovement(
483+
model=model, X_baseline=train_X, prune_baseline=False
484+
)
483485
options["initialization_strategy"] = "equally_spaced"
484486
candidates, _ = optimize_acqf_mixed_alternating(
485487
acq_function=acqf,

0 commit comments

Comments
 (0)