[Documentation] fix Inaccurate and incomplete documentation for SingleTaskMultiFidelityGP
#2847
Conversation
…eTaskMultiFidelityGP
|
Hi @Muhammad-Rebaal! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
| @@ -40,6 +40,15 @@ class LinearTruncatedFidelityKernel(Kernel): | |||
| polynomial kernel between `x_1[..., [f_1, f_2]]` and | |||
| `x_2[..., [f_1, f_2]]`. | |||
|
|
|||
| Note: | |||
| Fidelity interpretation: | |||
| - Higher numerical values represent higher fidelities (e.g., 3 > 2 > 1 > 0) | |||
There was a problem hiding this comment.
Not a good example if the fidelity values are clamped
| - Higher numerical values represent higher fidelities (e.g., 3 > 2 > 1 > 0) | |
| - Higher numerical values represent higher fidelities (e.g., 0.7 > 0.5 > 0) |
| - The kernel is designed so that higher fidelity points have higher correlation | ||
| with each other than with lower fidelity points |
There was a problem hiding this comment.
This seems like it would be the case for most if not all kernels? The kernel behavior is stationary w.r..t the fidelity parameters, right? As in, the covariance between 0.1 and 0.2 will be the same as the covariance between 0.8 and 0.9?
closes #2403
Hi @esantorella !
I've Improved the documentation related to
SingleTaskMultiFidelityGPandLinearTruncatedFidelityKernelto clearly express that higher numerical values represent higher fidelities. Could you please review my PR .Thank You !