Add CPUINFO_AVOID_SELINUX_VIOLATIONS to ARM parser#242
Open
prashanthswami wants to merge 1 commit intopytorch:mainfrom
Open
Add CPUINFO_AVOID_SELINUX_VIOLATIONS to ARM parser#242prashanthswami wants to merge 1 commit intopytorch:mainfrom
prashanthswami wants to merge 1 commit intopytorch:mainfrom
Conversation
For Android ARM builds, we previously introduced parsing of some non-standard properties: * ro.mediatek.platform * ro.chipname * ro.hardware.chipname In this context, 'non-standard' refers to properties that are not supported by all Android devices and in particular, are not specified as part of any domain in Android's platform sepolicy. As a result, processes that contain the cpuinfo library will generate SELinux denials until the system is modified to allow access to these properties, even though they are not valid on these systems. To avoid breaking existing behavior, introduce a negative-flag that allows users to compile out this behavior.
fbarchard
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Android ARM builds, we previously introduced parsing of some non-standard properties:
In this context, 'non-standard' refers to properties that are not supported by all Android devices and in particular, are not specified as part of any domain in Android's platform sepolicy. As a result, processes that contain the cpuinfo library will generate SELinux denials until the system is modified to allow access to these properties, even though they are not valid on these systems.
To avoid breaking existing behavior, introduce a negative-flag that allows users to compile out this behavior.