Conversation
|
Hi @eleir9268! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Please sign the CLA. |
| ENDIF() | ||
| ENDIF() | ||
|
|
||
| IF(CPUINFO_SUPPORTED_PLATFORM AND NOT QNX) |
There was a problem hiding this comment.
Is this really needed? make QNX like other x86 if you can
|
|
||
| # ---[ cpuinfo unit tests | ||
| IF(CPUINFO_SUPPORTED_PLATFORM AND CPUINFO_BUILD_UNIT_TESTS) | ||
| IF(CPUINFO_SUPPORTED_PLATFORM AND CPUINFO_BUILD_UNIT_TESTS AND NOT QNX) |
There was a problem hiding this comment.
ditto. if QNX is 'supported' and has unittests, remove AND NOT QNX.
If these dont work, disable 'CPUINFO_BUILD_UNIT_TESTS'?
| if CPUINFO_UNLIKELY (!cpuinfo_is_initialized) { | ||
| cpuinfo_log_fatal("cpuinfo_get_%s called before cpuinfo is initialized", "l1i_caches"); | ||
| } | ||
| #ifdef __QNXNTO__ |
There was a problem hiding this comment.
can these ifdef be removed and fill in the cpuinfo_cache like the rest of the platforms?
fbarchard
left a comment
fbarchard
left a comment
There was a problem hiding this comment.
looks generally okay but if QNX specific ifdefs can be reduced that would be good.
|
Sorry, still waiting to get traction on the CLA on our side of things. |
5 participants
See https://github.com/qnx-ports/build-files for build instructions.
Builds for both QNX SDP 8.0 and SDP 7.1.
We did not add tests, let me know if they're needed.