Skip to content

Set pyre-strict for passes unit tests. #11740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eigen-k
Copy link
Contributor

@eigen-k eigen-k commented Jun 16, 2025

Differential Revision: D76767018

Copy link

pytorch-bot bot commented Jun 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11740

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit f0effc0 with merge base 7bd15b9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 16, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76767018

@eigen-k eigen-k added topic: not user facing release notes: none Do not include this in the release notes labels Jun 16, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76767018

eigen-k added a commit to eigen-k/executorch that referenced this pull request Jun 16, 2025
Summary:
Pull Request resolved: pytorch#11740

This diff fixes this test failure https://www.internalfb.com/intern/test/844425134145806
...and also ensures same problem won't pop up for other unit tests.

Differential Revision: D76767018
@eigen-k eigen-k force-pushed the export-D76767018 branch from a33d7b7 to 212da9f Compare June 16, 2025 22:36
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76767018

eigen-k added a commit to eigen-k/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11740

This diff fixes this test failure https://www.internalfb.com/intern/test/844425134145806
...and also ensures same problem won't pop up for other unit tests.

Reviewed By: zonglinpeng

Differential Revision: D76767018
@eigen-k eigen-k force-pushed the export-D76767018 branch from 212da9f to 1b151b6 Compare June 17, 2025 17:59
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76767018

eigen-k added a commit to eigen-k/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11740

This diff fixes this test failure https://www.internalfb.com/intern/test/844425134145806
...and also ensures same problem won't pop up for other unit tests.

Reviewed By: zonglinpeng

Differential Revision: D76767018
@eigen-k eigen-k force-pushed the export-D76767018 branch from 1b151b6 to e4c565f Compare June 17, 2025 18:09
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76767018

eigen-k added a commit to eigen-k/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11740

This diff fixes this test failure https://www.internalfb.com/intern/test/844425134145806
...and also ensures same problem won't pop up for other unit tests.

Reviewed By: zonglinpeng

Differential Revision: D76767018
@eigen-k eigen-k force-pushed the export-D76767018 branch from e4c565f to 01b678a Compare June 17, 2025 20:29
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76767018

@eigen-k eigen-k force-pushed the export-D76767018 branch from 01b678a to 3b7b4e6 Compare June 17, 2025 22:18
eigen-k added a commit to eigen-k/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11740

This diff fixes this test failure https://www.internalfb.com/intern/test/844425134145806
...and also ensures same problem won't pop up for other unit tests.

Reviewed By: zonglinpeng

Differential Revision: D76767018
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76767018

eigen-k added a commit to eigen-k/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11740

This diff fixes this test failure https://www.internalfb.com/intern/test/844425134145806
...and also ensures same problem won't pop up for other unit tests.

Reviewed By: zonglinpeng

Differential Revision: D76767018
@eigen-k eigen-k force-pushed the export-D76767018 branch from 3b7b4e6 to f8c6b80 Compare June 17, 2025 22:28
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76767018

eigen-k added a commit to eigen-k/executorch that referenced this pull request Jun 17, 2025
Summary:
Pull Request resolved: pytorch#11740

This diff fixes this test failure https://www.internalfb.com/intern/test/844425134145806
...and also ensures same problem won't pop up for other unit tests.

Reviewed By: zonglinpeng

Differential Revision: D76767018
@eigen-k eigen-k force-pushed the export-D76767018 branch from f8c6b80 to 2ba7250 Compare June 17, 2025 23:42
Summary:
Pull Request resolved: pytorch#11740

This diff fixes this test failure https://www.internalfb.com/intern/test/844425134145806
...and also ensures same problem won't pop up for other unit tests.

Reviewed By: zonglinpeng

Differential Revision: D76767018
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76767018

@eigen-k eigen-k force-pushed the export-D76767018 branch from 2ba7250 to f0effc0 Compare June 17, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants