Implement python deserialize for flat_tensor #11779
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11779
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7a33ea8 with merge base 5960a4b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
GregoryComer
commented
Jun 18, 2025
| @@ -223,3 +225,32 @@ def test_serialize(self) -> None: | |||
| ) | |||
|
|
|||
| self.assertEqual(segments[2].offset + segments[2].size, len(segment_data)) | |||
|
|
|||
| def test_round_trip(self) -> None: | |||
There was a problem hiding this comment.
Note to reviewers: I considered adding a deserialize test in the same vein as the serialize test, but it's a bit awkward to do, in that we'd need to construct a binary input without using the existing serialization logic, Could also include a pre-serialized artifact, but I think this coverage is sufficient in conjunction with the serialize test. Feel free to let me know if you want to see more coverage.
GregoryComer
added
the
release notes: none
GregoryComer
force-pushed
the
flat-tensor-deserialize
branch
from
1422bfe to
7a33ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the deserialize function in the Python FlatTensorSerializer class. This allows for loading flatbuffer data from a Python environment.
Test plan
I've added an additional test in
extension/flat_tensor/test/test_serialize.pyto cover the deserialize path.