Skip to content

Fix typo for 16a4w_block quantization #11821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fix typo for 16a4w_block quantization #11821

merged 1 commit into from
Jun 20, 2025

Conversation

rohansjoshi
Copy link
Contributor

Differential Revision: D76949897

@rohansjoshi rohansjoshi requested a review from cccclai as a code owner June 20, 2025 15:25
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11821

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8a917e9 with merge base 496cb05 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76949897

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

rohansjoshi added a commit to rohansjoshi/executorch that referenced this pull request Jun 20, 2025
@rohansjoshi @facebook-github-bot
Fix typo for 16a4w_block quantization (pytorch#11821)
70ea33f 
Summary: Pull Request resolved: pytorch#11821

Differential Revision: D76949897
@rohansjoshi @facebook-github-bot
Fix typo for 16a4w_block quantization (pytorch#11821)
8a917e9 
Summary: Pull Request resolved: pytorch#11821

Differential Revision: D76949897
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76949897

cccclai
cccclai approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@cccclai
Copy link
Contributor

cccclai commented Jun 20, 2025

@winskuo-quic @haowhsu-quic fixing the type as fyi

@facebook-github-bot facebook-github-bot merged commit 63b047b into pytorch:main Jun 20, 2025
104 checks passed
@haowhsu-quic
Copy link
Collaborator

haowhsu-quic commented Jun 21, 2025 •
edited
Loading

Oh... I should reexport all the variants and test the accuracy. Thank you.
Will review PR more carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohansjoshi @facebook-github-bot @cccclai @haowhsu-quic