Skip to content

[ET-VK][ez] Always partition batch norm as it will be fused#17508

Merged
meta-codesync[bot] merged 3 commits intogh/SS-JIA/436/basefrom
gh/SS-JIA/436/head
Feb 20, 2026
Merged

[ET-VK][ez] Always partition batch norm as it will be fused#17508
meta-codesync[bot] merged 3 commits intogh/SS-JIA/436/basefrom
gh/SS-JIA/436/head

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Feb 17, 2026

The batch norm operator registration had a check_batch_norm_node guard that restricted partitioning to 4D input tensors only. Since batch norm is always fused with adjacent operations during graph compilation, this restriction is unnecessary and prevents valid models from being partitioned to the Vulkan backend. Remove the guard so batch norm is always eligible for Vulkan partitioning regardless of input dimensionality.

Differential Revision: [D93511630](https://our.internmc.facebook.com/intern/diff/D93511630/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 17, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17508

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 0f351d4 with merge base 7b843e4 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SS-JIA pushed a commit that referenced this pull request Feb 17, 2026
The batch norm operator registration had a check_batch_norm_node guard that restricted partitioning to 4D input tensors only. Since batch norm is always fused with adjacent operations during graph compilation, this restriction is unnecessary and prevents valid models from being partitioned to the Vulkan backend. Remove the guard so batch norm is always eligible for Vulkan partitioning regardless of input dimensionality.

Differential Revision: [D93511630](https://our.internmc.facebook.com/intern/diff/D93511630/)

ghstack-source-id: 341964638
Pull Request resolved: #17508
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

The batch norm operator registration had a check_batch_norm_node guard that restricted partitioning to 4D input tensors only. Since batch norm is always fused with adjacent operations during graph compilation, this restriction is unnecessary and prevents valid models from being partitioned to the Vulkan backend. Remove the guard so batch norm is always eligible for Vulkan partitioning regardless of input dimensionality.

Differential Revision: [D93511630](https://our.internmc.facebook.com/intern/diff/D93511630/)

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Feb 18, 2026
Pull Request resolved: #17508

The batch norm operator registration had a check_batch_norm_node guard that restricted partitioning to 4D input tensors only. Since batch norm is always fused with adjacent operations during graph compilation, this restriction is unnecessary and prevents valid models from being partitioned to the Vulkan backend. Remove the guard so batch norm is always eligible for Vulkan partitioning regardless of input dimensionality.
ghstack-source-id: 342410944
@exported-using-ghexport

Differential Revision: [D93511630](https://our.internmc.facebook.com/intern/diff/D93511630/)
The batch norm operator registration had a check_batch_norm_node guard that restricted partitioning to 4D input tensors only. Since batch norm is always fused with adjacent operations during graph compilation, this restriction is unnecessary and prevents valid models from being partitioned to the Vulkan backend. Remove the guard so batch norm is always eligible for Vulkan partitioning regardless of input dimensionality.

Differential Revision: [D93511630](https://our.internmc.facebook.com/intern/diff/D93511630/)

[ghstack-poisoned]
@meta-codesync meta-codesync bot merged commit 8ef5417 into gh/SS-JIA/436/base Feb 20, 2026
170 of 178 checks passed
@meta-codesync meta-codesync bot deleted the gh/SS-JIA/436/head branch February 20, 2026 01:13
SS-JIA pushed a commit that referenced this pull request Feb 20, 2026
Pull Request resolved: #17508

The batch norm operator registration had a check_batch_norm_node guard that restricted partitioning to 4D input tensors only. Since batch norm is always fused with adjacent operations during graph compilation, this restriction is unnecessary and prevents valid models from being partitioned to the Vulkan backend. Remove the guard so batch norm is always eligible for Vulkan partitioning regardless of input dimensionality.
ghstack-source-id: 342806074
@exported-using-ghexport

Differential Revision: [D93511630](https://our.internmc.facebook.com/intern/diff/D93511630/)
SS-JIA pushed a commit that referenced this pull request Feb 20, 2026
Pull Request resolved: #17508

The batch norm operator registration had a check_batch_norm_node guard that restricted partitioning to 4D input tensors only. Since batch norm is always fused with adjacent operations during graph compilation, this restriction is unnecessary and prevents valid models from being partitioned to the Vulkan backend. Remove the guard so batch norm is always eligible for Vulkan partitioning regardless of input dimensionality.
ghstack-source-id: 342806074
@exported-using-ghexport

Differential Revision: [D93511630](https://our.internmc.facebook.com/intern/diff/D93511630/)
SS-JIA pushed a commit that referenced this pull request Feb 20, 2026
Pull Request resolved: #17508

The batch norm operator registration had a check_batch_norm_node guard that restricted partitioning to 4D input tensors only. Since batch norm is always fused with adjacent operations during graph compilation, this restriction is unnecessary and prevents valid models from being partitioned to the Vulkan backend. Remove the guard so batch norm is always eligible for Vulkan partitioning regardless of input dimensionality.
ghstack-source-id: 342806074
@exported-using-ghexport

Differential Revision: [D93511630](https://our.internmc.facebook.com/intern/diff/D93511630/)
SS-JIA pushed a commit that referenced this pull request Feb 20, 2026
Pull Request resolved: #17508

The batch norm operator registration had a check_batch_norm_node guard that restricted partitioning to 4D input tensors only. Since batch norm is always fused with adjacent operations during graph compilation, this restriction is unnecessary and prevents valid models from being partitioned to the Vulkan backend. Remove the guard so batch norm is always eligible for Vulkan partitioning regardless of input dimensionality.
ghstack-source-id: 342806074
@exported-using-ghexport

Differential Revision: [D93511630](https://our.internmc.facebook.com/intern/diff/D93511630/)
SS-JIA pushed a commit that referenced this pull request Feb 20, 2026
Pull Request resolved: #17508

The batch norm operator registration had a check_batch_norm_node guard that restricted partitioning to 4D input tensors only. Since batch norm is always fused with adjacent operations during graph compilation, this restriction is unnecessary and prevents valid models from being partitioned to the Vulkan backend. Remove the guard so batch norm is always eligible for Vulkan partitioning regardless of input dimensionality.
ghstack-source-id: 342806074
@exported-using-ghexport

Differential Revision: [D93511630](https://our.internmc.facebook.com/intern/diff/D93511630/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants