Added EXP3 Scoring function in continuation with pr #2358 #3013
+216
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3013
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vmoens
reviewed
Jun 19, 2025
| pass | ||
|
|
||
|
|
||
| class PUCTScore(MCTSScore): |
There was a problem hiding this comment.
Let's add some docstrings there!
Should include an example
| return node | ||
|
|
||
|
|
||
| class UCBScore(MCTSScore): |
| return node | ||
|
|
||
|
|
||
| class EXP3Score(MCTSScore): |
| node.set(self.weights_key, weights) | ||
|
|
||
|
|
||
| class MCTSScores(Enum): |
There was a problem hiding this comment.
@vmoens ?? Any changes needed here ?
There was a problem hiding this comment.
Sorry but I didn't get that 😅
|
|
||
| def update_weights( | ||
| self, node: TensorDictBase, action_idx: int, reward: float | ||
| ) -> None: |
There was a problem hiding this comment.
Public methods need docstrings too
|
@vmoens I branched out from your PR branch. I will be adding more docstrings, tests and also the other two methods which are yet to be implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added EXP3 Scoring function in continuation with pr #2358
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!