Skip to content

[Benchmark] Reorg and Clean LLMs component #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 3, 2025
Merged

[Benchmark] Reorg and Clean LLMs component #6351

merged 17 commits into from
Mar 3, 2025

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Mar 1, 2025 •
edited
Loading

Issue: #6323

  • Use UserReducer to handle the benchmark dashboard props
  • Restruct the LLMsPage, move picker logics to UI component, and render the dropdown list dynamically.
  • Pass props instead of each param to llmsReport for easy maintainance

Demo: https://torchci-4sjlqbjzx-fbopensource.vercel.app/benchmark/llms?repoName=pytorch%2Fexecutorch

Next steps:

  • keep cleaning the rest of component
  • introduct repo speciifc configuration logic

@vercel Vercel
Copy link

vercel bot commented Mar 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Mar 3, 2025 10:17pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2025
@yangw-dev yangw-dev requested review from clee2000 and ZainRizvi March 3, 2025 21:30
@yangw-dev yangw-dev marked this pull request as ready for review March 3, 2025 21:31
@yangw-dev yangw-dev changed the title [Benchmark] Clean and Make things configuration [Benchmark] Reorg and Clean LLMs component Mar 3, 2025
clee2000
clee2000 reviewed Mar 3, 2025
View reviewed changes
yangw-dev
yangw-dev commented Mar 3, 2025
View reviewed changes
Copy link
Contributor Author

@yangw-dev yangw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@yangw-dev yangw-dev requested a review from clee2000 March 3, 2025 21:49
@yangw-dev yangw-dev merged commit e094fce into main Mar 3, 2025
6 checks passed
@yangw-dev yangw-dev deleted the improve1 branch March 3, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clee2000 clee2000 clee2000 approved these changes

@ZainRizvi ZainRizvi Awaiting requested review from ZainRizvi

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangw-dev @clee2000 @facebook-github-bot