Skip to content

Add DCP async checkpointing for lora dpo recipe #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 23, 2025

Conversation

ankitageorge
Copy link
Contributor

@ankitageorge ankitageorge commented Jun 18, 2025

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?

  1. CheckpointClient initialization was before dist initialization, causing bugs
  2. If the epoch is faster than async checkpointing (this would only really happen in a test, not real life scenario) then it causes hanging because we're trying to access CPU staging before previous has cleared. This is solved for already for back to back async checkpointing, but for a sync checkpoint after an async checkpointing, we didn't have the logic to properly wait for the async checkpoint to complete before saving the sync checkpoint.

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • [x ] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • [ x] add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • [x ] run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Jun 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2835

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6da2f00 with merge base 5b2e881 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2025
@ankitageorge ankitageorge changed the title Lora dpo dcp Add DCP async checkpointing for lora dpo recipe Jun 18, 2025
@ankitageorge ankitageorge marked this pull request as ready for review June 18, 2025 19:15
@ankitageorge ankitageorge requested a review from joecummings June 18, 2025 19:37
Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@ankitageorge ankitageorge merged commit 375627f into pytorch:main Jun 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants