Update Custom C++ and CUDA Operators to use PyTorch stable API/ABI #3701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3701
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a8c5294 with merge base 10eefc3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mikaylagawarecki
force-pushed
the
stable_custom_op
branch
from
479f1c2 to
a8c5294
Compare
| Use ``torch.library.register_autograd`` to add training support for an operator. Prefer | ||
| this over directly using Python ``torch.autograd.Function`` or C++ ``torch::autograd::Function``; | ||
| you must use those in a very specific way to avoid silent incorrectness (see | ||
| this over directly using Python ``torch.autograd.Function`` (see |
Contributor
Author
There was a problem hiding this comment.
remove reference to torch::autograd::Function since we don't support that in stable API/ABI
zou3519
reviewed
Dec 22, 2025
| Defining the custom op and adding backend implementations | ||
| --------------------------------------------------------- | ||
| First, let's write a C++ function that computes ``mymuladd``: | ||
| First, let's write a C++ function that computes ``mymuladd`` using the LibTorch Stable ABI: |
Contributor
There was a problem hiding this comment.
Hmm same question here as on the other PR. Do we have enough in 2.10 to always recommend the libtorch stable APIs? If not, then we're going to want a section with libtorch stable apis and a section with the regular libtorch APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
advanced_source/cpp_custom_ops.rstto libtorch stable ABI/API. Accompanying change toextension-cppChecklist