Make nms support tensor values for iou_threshold

[jansel]

Not sure if this is something we want to support, but it fixes pytorch/pytorch#156722

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9121

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 107186a with merge base 0721867 ():

NEW FAILURES - The following jobs have failed:

• Build M1 Wheels / pytorch/vision / build-wheel-py3_9-cpu (gh)
  Process completed with exit code 1.
• Build M1 Wheels / pytorch/vision / upload / upload-wheel-py3_9-cpu (gh)
  Unable to download artifact(s): Artifact not found for name: pytorch_vision__3.9_cpu_
• Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
  test/test_ops.py::TestNMS::test_nms_compile_tensor_iou_threshold[batched_nms]
• Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
  test/test_ops.py::TestNMS::test_nms_compile_tensor_iou_threshold[batched_nms]
• Tests / unittests-windows (3.12, windows.4xlarge, cpu) / windows-job (gh)
  test/test_ops.py::TestNMS::test_nms_compile_tensor_iou_threshold[batched_nms]
• Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
  test/test_ops.py::TestNMS::test_nms_compile_tensor_iou_threshold[batched_nms]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[NicolasHug]

Thanks for the PR @jansel . I'm not sure we'll want to merge this, I think users should just pass a float as you noted. I'll reply on pytorch/pytorch#156722 and ask for more details from OP, if really there is a good reason users can't call item() themselves then we can reconsider.
I'm prefer not merging this for now without learning more, because it's possible we'd have to do the same conversion for all non-tensor parameters in all ops.

[jansel]

Thanks, that seems fine to me. I believe this issue might be from a fuzz tester.