Optimize as_strided_copy fast path to support offset#9728
Open
Zantares wants to merge 1 commit intopytorch:masterfrom
Open
Optimize as_strided_copy fast path to support offset#9728Zantares wants to merge 1 commit intopytorch:masterfrom
Zantares wants to merge 1 commit intopytorch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the
as_strided_copyfast path to supportoffset.Negative case (happens in the default path of torch LSTM):
HLO before opt:
result0W/O offset usedsliceresult1W/ offset usedtakewhich contains many opsThe 2 operations are very similar except the offset part. In fact the 2nd result can be directly sliced after adding the
offsetto thestartparameter ofslice. This PR is to support such optimization inas_strided_copywhen the offset happens in the same dimension ofslice.The optimized HLO: