Thr3mi L1C reader #2908
Thr3mi L1C reader #2908
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 new file with code health below 9.00)
(2 files with Bumpy Road Ahead, Deep, Nested Complexity)
(2 files with Complex Method, Large Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| New code is healthy | Violations | Code Health Impact | |
|---|---|---|---|
| test_thr3mi_l1c_nc.py | 3 rules | 10.00 → 8.86 | Suppress |
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| test_thr3mi_l1c_nc.py | 2 critical rules | 10.00 → 8.86 | Suppress |
| thr3mi_l1c_nc.py | 1 critical rule | 10.00 → 9.54 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| test_thr3mi_l1c_nc.py | 1 advisory rule | 10.00 → 8.86 | Suppress |
| thr3mi_l1c_nc.py | 1 advisory rule | 10.00 → 9.54 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Deep, Nested Complexity test_thr3mi_l1c_nc.py: TestThr3miNCL1cFileHandler.test_file_reading
- Large Method test_thr3mi_l1c_nc.py: TestThr3miNCL1cFileHandler.test_file_reading
- Complex Method thr3mi_l1c_nc.py: Thr3miL1cNCFileHandler.get_dataset
- Bumpy Road Ahead thr3mi_l1c_nc.py: Thr3miL1cNCFileHandler.get_dataset
- Bumpy Road Ahead test_thr3mi_l1c_nc.py: TestThr3miNCL1cFileHandler.test_file_reading
Annotations
Check warning on line 100 in satpy/readers/thr3mi_l1c_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
Thr3miL1cNCFileHandler.get_dataset has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 100 in satpy/readers/thr3mi_l1c_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
Thr3miL1cNCFileHandler.get_dataset has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 228 in satpy/tests/reader_tests/test_thr3mi_l1c_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Large Method
TestThr3miNCL1cFileHandler.test_file_reading has 75 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 228 in satpy/tests/reader_tests/test_thr3mi_l1c_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
TestThr3miNCL1cFileHandler.test_file_reading has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 228 in satpy/tests/reader_tests/test_thr3mi_l1c_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Deep, Nested Complexity
TestThr3miNCL1cFileHandler.test_file_reading has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.