Skip to content

Introduce project file and data for generating screenshots for fix and check algorithms #10164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Introduce project file and data for generating screenshots for fix and check algorithms #10164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce97ceb
Introduce project file and data for generating screenshots for fix an…
DelazJ Aug 17, 2025
caeb780
Update screenshots for "Feature inside polygon" and "Delete features"…
DelazJ Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/user_manual/processing_algs/qgis/fixgeometry.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ Deletes error features based on an error layer from the check geometry algorithm
.. figure:: img/fix_geometry_deletefeatures.png
:align: center

Before and after deleting features inside a polygon.
Fixing error from the "Features inside polygon" algorithm check.

.. seealso:: :ref:`qgisdeleteduplicategeometries`, :ref:`qgisdropgeometries`

Expand Down
Binary file modified docs/user_manual/processing_algs/qgis/img/check_geometry_featuresinsidepolygon.png
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion here is, for check algs, show the input feature(s)/layer(s) i.e. the blue rectangle and the yellow orange, and the output of the alg, as a point and as a limit of the erroneous feature (both in red)

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/user_manual/processing_algs/qgis/img/fix_geometry_deletefeatures.png
View file
Open in desktop
Copy link
Collaborator Author

@DelazJ DelazJ Aug 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the fix alg context, I propose to have a before/after:

  • the before being the input feature(s)/layer(s), + the identified errors as a point and a feature (I wonder if we should keep the feature (represented with red stroke. Is it not too much? But on the other side, keeping it allows to start from the check alg output state, thus reuse the check image).
  • the after only shows the input layer fixed (+ the checked against feature/layer if any)

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added qgis-projects/user_manual/check_fix_algorithms.gpkg
View file
Open in desktop
Binary file not shown.