Skip to content

Commit 068098a

Browse files
alexbruyalexbruy
committed
more const
1 parent f6eba0a commit 068098a

27 files changed

+25
-73
lines changed

‎src/analysis/processing/qgsalgorithmcheckgeometryangle.cpp‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ void QgsGeometryCheckAngleAlgorithm::initAlgorithm( const QVariantMap &configura
7575
{
7676
Q_UNUSED( configuration )
7777

78-
// inputs
7978
addParameter(
8079
new QgsProcessingParameterFeatureSource(
8180
QStringLiteral( "INPUT" ), QObject::tr( "Input layer" ),
@@ -89,7 +88,6 @@ void QgsGeometryCheckAngleAlgorithm::initAlgorithm( const QVariantMap &configura
8988
QStringLiteral( "MIN_ANGLE" ), QObject::tr( "Minimum angle (in degrees)" ), Qgis::ProcessingNumberParameterType::Double, 0, false, 0.0, 180.0
9089
) );
9190

92-
// outputs
9391
addParameter( new QgsProcessingParameterFeatureSink(
9492
QStringLiteral( "ERRORS" ), QObject::tr( "Small angle errors" ), Qgis::ProcessingSourceType::VectorPoint
9593
) );
@@ -131,8 +129,8 @@ QVariantMap QgsGeometryCheckAngleAlgorithm::processAlgorithm( const QVariantMap
131129
if ( !input )
132130
throw QgsProcessingException( invalidSourceError( parameters, QStringLiteral( "INPUT" ) ) );
133131

134-
QString uniqueIdFieldName( parameterAsString( parameters, QStringLiteral( "UNIQUE_ID" ), context ) );
135-
int uniqueIdFieldIdx = input->fields().indexFromName( uniqueIdFieldName );
132+
const QString uniqueIdFieldName( parameterAsString( parameters, QStringLiteral( "UNIQUE_ID" ), context ) );
133+
const int uniqueIdFieldIdx = input->fields().indexFromName( uniqueIdFieldName );
136134
if ( uniqueIdFieldIdx == -1 )
137135
throw QgsProcessingException( QObject::tr( "Missing field %1 in input layer" ).arg( uniqueIdFieldName ) );
138136

‎src/analysis/processing/qgsalgorithmcheckgeometryarea.cpp‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ void QgsGeometryCheckAreaAlgorithm::initAlgorithm( const QVariantMap &configurat
7575
{
7676
Q_UNUSED( configuration )
7777

78-
// inputs
7978
addParameter(
8079
new QgsProcessingParameterFeatureSource(
8180
QStringLiteral( "INPUT" ), QObject::tr( "Input layer" ),
@@ -89,7 +88,6 @@ void QgsGeometryCheckAreaAlgorithm::initAlgorithm( const QVariantMap &configurat
8988
QStringLiteral( "AREATHRESHOLD" ), QObject::tr( "Area threshold" ), 0, QStringLiteral( "INPUT" )
9089
) );
9190

92-
// outputs
9391
addParameter( new QgsProcessingParameterFeatureSink(
9492
QStringLiteral( "ERRORS" ), QObject::tr( "Small polygons errors" ), Qgis::ProcessingSourceType::VectorPoint
9593
) );
@@ -134,8 +132,8 @@ QVariantMap QgsGeometryCheckAreaAlgorithm::processAlgorithm( const QVariantMap &
134132
if ( !input )
135133
throw QgsProcessingException( invalidSourceError( parameters, QStringLiteral( "INPUT" ) ) );
136134

137-
QString uniqueIdFieldName( parameterAsString( parameters, QStringLiteral( "UNIQUE_ID" ), context ) );
138-
int uniqueIdFieldIdx = input->fields().indexFromName( uniqueIdFieldName );
135+
const QString uniqueIdFieldName( parameterAsString( parameters, QStringLiteral( "UNIQUE_ID" ), context ) );
136+
const int uniqueIdFieldIdx = input->fields().indexFromName( uniqueIdFieldName );
139137
if ( uniqueIdFieldIdx == -1 )
140138
throw QgsProcessingException( QObject::tr( "Missing field %1 in input layer" ).arg( uniqueIdFieldName ) );
141139

@@ -156,7 +154,7 @@ QVariantMap QgsGeometryCheckAreaAlgorithm::processAlgorithm( const QVariantMap &
156154

157155
QgsProcessingMultiStepFeedback multiStepFeedback( 3, feedback );
158156

159-
QgsProject *project = QgsProject::instance();
157+
const QgsProject *project = QgsProject::instance();
160158

161159
QgsGeometryCheckContext checkContext = QgsGeometryCheckContext( mTolerance, input->sourceCrs(), project->transformContext(), project, uniqueIdFieldIdx );
162160

‎src/analysis/processing/qgsalgorithmcheckgeometrycontained.cpp‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ void QgsGeometryCheckContainedAlgorithm::initAlgorithm( const QVariantMap &confi
7676
{
7777
Q_UNUSED( configuration )
7878

79-
// inputs
8079
addParameter( new QgsProcessingParameterFeatureSource(
8180
QStringLiteral( "INPUT" ), QObject::tr( "Input layer" ),
8281
QList<int>() << static_cast<int>( Qgis::ProcessingSourceType::VectorPoint )
@@ -90,7 +89,6 @@ void QgsGeometryCheckContainedAlgorithm::initAlgorithm( const QVariantMap &confi
9089
QStringLiteral( "POLYGONS" ), QObject::tr( "Polygon layers" ), Qgis::ProcessingSourceType::VectorPolygon
9190
) );
9291

93-
// outputs
9492
addParameter( new QgsProcessingParameterFeatureSink(
9593
QStringLiteral( "ERRORS" ), QObject::tr( "Errors from contained features" ), Qgis::ProcessingSourceType::VectorPoint
9694
) );
@@ -139,7 +137,6 @@ QVariantMap QgsGeometryCheckContainedAlgorithm::processAlgorithm( const QVariant
139137
if ( polygonLayers.isEmpty() )
140138
throw QgsProcessingException( invalidSourceError( parameters, QStringLiteral( "POLYGONS" ) ) );
141139

142-
143140
const QString uniqueIdFieldName( parameterAsString( parameters, QStringLiteral( "UNIQUE_ID" ), context ) );
144141
const int uniqueIdFieldIdx = input->fields().indexFromName( uniqueIdFieldName );
145142
if ( uniqueIdFieldIdx == -1 )

‎src/analysis/processing/qgsalgorithmcheckgeometrydangle.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ QgsFields QgsGeometryCheckDangleAlgorithm::outputFields()
118118
return fields;
119119
}
120120

121-
122121
QVariantMap QgsGeometryCheckDangleAlgorithm::processAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback )
123122
{
124123
QString dest_output;

‎src/analysis/processing/qgsalgorithmcheckgeometryduplicate.cpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ QgsFields QgsGeometryCheckDuplicateAlgorithm::outputFields()
124124
return fields;
125125
}
126126

127-
128127
QVariantMap QgsGeometryCheckDuplicateAlgorithm::processAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback )
129128
{
130129
QString dest_output;
@@ -140,7 +139,6 @@ QVariantMap QgsGeometryCheckDuplicateAlgorithm::processAlgorithm( const QVariant
140139
throw QgsProcessingException( QObject::tr( "Missing field %1 in input layer" ).arg( uniqueIdFieldName ) );
141140

142141
const QgsField uniqueIdField = input->fields().at( uniqueIdFieldIdx );
143-
144142
QgsFields fields = outputFields();
145143
fields.append( uniqueIdField );
146144

‎src/analysis/processing/qgsalgorithmcheckgeometryduplicatenodes.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ QgsFields QgsGeometryCheckDuplicateNodesAlgorithm::outputFields()
119119
return fields;
120120
}
121121

122-
123122
QVariantMap QgsGeometryCheckDuplicateNodesAlgorithm::processAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback )
124123
{
125124
QString dest_output;

‎src/analysis/processing/qgsalgorithmcheckgeometryfollowboundaries.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ QgsFields QgsGeometryCheckFollowBoundariesAlgorithm::outputFields()
122122
return fields;
123123
}
124124

125-
126125
QVariantMap QgsGeometryCheckFollowBoundariesAlgorithm::processAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback )
127126
{
128127
QString dest_output;

‎src/analysis/processing/qgsalgorithmcheckgeometrygap.cpp‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ QgsFields QgsGeometryCheckGapAlgorithm::outputFields()
139139
return fields;
140140
}
141141

142-
143142
QVariantMap QgsGeometryCheckGapAlgorithm::processAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback )
144143
{
145144
QString dest_output;
@@ -166,8 +165,8 @@ QVariantMap QgsGeometryCheckGapAlgorithm::processAlgorithm( const QVariantMap &p
166165
if ( !sink_errors )
167166
throw QgsProcessingException( invalidSinkError( parameters, QStringLiteral( "ERRORS" ) ) );
168167

169-
QString uniqueIdFieldName( parameterAsString( parameters, QStringLiteral( "UNIQUE_ID" ), context ) );
170-
int uniqueIdFieldIdx = input->fields().indexFromName( uniqueIdFieldName );
168+
const QString uniqueIdFieldName( parameterAsString( parameters, QStringLiteral( "UNIQUE_ID" ), context ) );
169+
const int uniqueIdFieldIdx = input->fields().indexFromName( uniqueIdFieldName );
171170
if ( uniqueIdFieldIdx == -1 )
172171
throw QgsProcessingException( QObject::tr( "Missing field %1 in input layer" ).arg( uniqueIdFieldName ) );
173172

‎src/analysis/processing/qgsalgorithmcheckgeometryhole.cpp‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ void QgsGeometryCheckHoleAlgorithm::initAlgorithm( const QVariantMap &configurat
7575
{
7676
Q_UNUSED( configuration )
7777

78-
// inputs
7978
addParameter(
8079
new QgsProcessingParameterFeatureSource(
8180
QStringLiteral( "INPUT" ), QObject::tr( "Input layer" ),
@@ -86,7 +85,6 @@ void QgsGeometryCheckHoleAlgorithm::initAlgorithm( const QVariantMap &configurat
8685
QStringLiteral( "UNIQUE_ID" ), QObject::tr( "Unique feature identifier" ), QString(), QStringLiteral( "INPUT" )
8786
) );
8887

89-
// outputs
9088
addParameter( new QgsProcessingParameterFeatureSink(
9189
QStringLiteral( "ERRORS" ), QObject::tr( "Holes errors" ), Qgis::ProcessingSourceType::VectorPoint
9290
) );
@@ -132,8 +130,8 @@ QVariantMap QgsGeometryCheckHoleAlgorithm::processAlgorithm( const QVariantMap &
132130
if ( !input )
133131
throw QgsProcessingException( invalidSourceError( parameters, QStringLiteral( "INPUT" ) ) );
134132

135-
QString uniqueIdFieldName( parameterAsString( parameters, QStringLiteral( "UNIQUE_ID" ), context ) );
136-
int uniqueIdFieldIdx = input->fields().indexFromName( uniqueIdFieldName );
133+
const QString uniqueIdFieldName( parameterAsString( parameters, QStringLiteral( "UNIQUE_ID" ), context ) );
134+
const int uniqueIdFieldIdx = input->fields().indexFromName( uniqueIdFieldName );
137135
if ( uniqueIdFieldIdx == -1 )
138136
throw QgsProcessingException( QObject::tr( "Missing field %1 in input layer" ).arg( uniqueIdFieldName ) );
139137

@@ -154,7 +152,7 @@ QVariantMap QgsGeometryCheckHoleAlgorithm::processAlgorithm( const QVariantMap &
154152

155153
QgsProcessingMultiStepFeedback multiStepFeedback( 3, feedback );
156154

157-
QgsProject *project = QgsProject::instance();
155+
const QgsProject *project = QgsProject::instance();
158156

159157
QgsGeometryCheckContext checkContext = QgsGeometryCheckContext( mTolerance, input->sourceCrs(), project->transformContext(), project, uniqueIdFieldIdx );
160158

‎src/analysis/processing/qgsalgorithmcheckgeometrylineintersection.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ QgsFields QgsGeometryCheckLineIntersectionAlgorithm::outputFields()
118118
return fields;
119119
}
120120

121-
122121
QVariantMap QgsGeometryCheckLineIntersectionAlgorithm::processAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback )
123122
{
124123
QString dest_output;

0 commit comments

Comments
 (0)