feat(#62838): cleaned up showDetails logic

Author: captaincoordinates

src/gui/stac/qgsstacdataitemguiprovider.cpp

@@ -188,36 +188,36 @@ void QgsStacDataItemGuiProvider::loadConnections( QgsDataItem *item )
 
 void QgsStacDataItemGuiProvider::showDetails( QgsDataItem *item )
 {
-  QgsStacObject *stacObj = nullptr;
   QString authcfg;
 
-  if ( QgsStacItemItem *itemItem = qobject_cast<QgsStacItemItem *>( item ) )
+  QgsStacItemItem *itemItem = qobject_cast<QgsStacItemItem *>( item );
+  QgsStacCatalogItem *catalogItem = qobject_cast<QgsStacCatalogItem *>( item );
+  QgsStacAssetItem *assetItem = qobject_cast<QgsStacAssetItem *>( item );
+
+  if ( !( itemItem || catalogItem || assetItem ) )
   {
-    stacObj = itemItem->stacItem();
-    authcfg = itemItem->stacController()->authCfg();
+    return;
   }
-  else if ( QgsStacCatalogItem *catalogItem = qobject_cast<QgsStacCatalogItem *>( item ) )
+
+  QgsStacObjectDetailsDialog d;
+  if ( itemItem )
   {
-    stacObj = catalogItem->stacCatalog();
+    authcfg = itemItem->stacController()->authCfg();
+    d.setContentFromStacObject( itemItem->stacItem() );
   }
-  if ( stacObj )
+  else if ( catalogItem )
   {
-    QgsStacObjectDetailsDialog d;
-    d.setAuthcfg( authcfg );
-    d.setContentFromStacObject( stacObj );
-    d.exec();
-    return;
+    d.setContentFromStacObject( catalogItem->stacCatalog() );
   }
-
-  if ( QgsStacAssetItem *assetItem = qobject_cast<QgsStacAssetItem *>( item ) )
+  else if ( assetItem )
   {
-    QgsStacObjectDetailsDialog d;
     QgsStacItemItem *itemItem = qobject_cast<QgsStacItemItem *>( assetItem->parent() );
-    d.setAuthcfg( itemItem->stacController()->authCfg() );
+    authcfg = itemItem->stacController()->authCfg();
     d.setContentFromStacAsset( assetItem->name(), assetItem->stacAsset() );
-    d.exec();
-    return;
   }
+  d.setAuthcfg( authcfg );
+  d.exec();
+  return;
 }
 
 void QgsStacDataItemGuiProvider::downloadAssets( QgsDataItem *item, QgsDataItemGuiContext context )