Postgresql refactor some qgspostgresutils functions #63267
+48
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic schema, also improve SQL queries a bit
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Sep 25, 2025
| void QgsPostgresProvider::setEditorWidgets() | ||
| { | ||
| if ( !QgsPostgresUtils::tableExists( connectionRO(), EDITOR_WIDGET_STYLES_TABLE ) ) | ||
| if ( !QgsPostgresUtils::tableExists( connectionRO(), QStringLiteral( "public" ), EDITOR_WIDGET_STYLES_TABLE ) ) |
There was a problem hiding this comment.
There's potentially a regression here -- the existing code supports these tables being placed in a default schema which is NOT "public". I think the tableExists/columnExists methods should support empty string for schema to use the current logic, which doesn't check the schema.
There was a problem hiding this comment.
Ok, I did not realize that. Should be fixed as requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
QgsPostgresUtilsfunctionscolumnExists()andtableExists()withschemaparameter, so that they can be used to search for colums and tables outside of public schema.This is intended for future updates and work.