-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Move networklogger to gui #63269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Move networklogger to gui #63269
Conversation
🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
668bfbf
to
7c0926b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you motivations to move it in gui module ? especially when you don't enable sip API.
@troopa81 thanks for the review! I would like to use the network logger widget inside an external application that uses QGIS as a library. |
Maybe, yes. I don't know the policy exactly in this kind of situation. |
I think keeping them out of the bindings is the right move -- there's too much risk of abuse / nasty behavior if we expose these classes for use in Python. |
681d58d
to
ef1ad53
Compare
Tests failed for Qt 6 (ALL_BUT_PROVIDERS - ubuntu)One or more tests failed using the build from commit ef1ad53 layout_export_marker_masking_w_effectslayout_export_marker_masking_w_effectsTest failed at test_layout_export_marker_masking_w_effects at tests/src/python/test_selective_masking.py:1295 Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_marker_masking_w_effects/layout_export_marker_masking_w_effects.png (found 20 pixels different) layout_export_marker_masking_w_transparencylayout_export_marker_masking_w_transparencyTest failed at test_layout_export_marker_masking_w_transparency at tests/src/python/test_selective_masking.py:1383 Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_marker_masking_w_transparency/layout_export_marker_masking_w_transparency.png (found 23 pixels different) layout_export_text_masking_w_transparencylayout_export_text_masking_w_transparencyTest failed at test_layout_export_text_masking_w_transparency at tests/src/python/test_selective_masking.py:1414 Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_text_masking_w_transparency/layout_export_text_masking_w_transparency.png (found 12 pixels different) layout_export_w_effectslayout_export_w_effectsTest failed at test_layout_export_w_effects at tests/src/python/test_selective_masking.py:1204 Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_w_effects/layout_export_w_effects.png (found 6 pixels different) layout_export_force_raster_renderlayout_export_force_raster_renderTest failed at test_layout_export_w_force_raster_render at tests/src/python/test_selective_masking.py:1357 Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_force_raster_render/layout_export_force_raster_render.png (found 94 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
public: | ||
//! Custom node data roles | ||
enum Roles | ||
enum class Roles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also move this to Qgis namespace? (and rename to DevToolsNodeRole, and remove "Role" prefix from the values)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done thanks
3f0902e
to
72c5db3
Compare
72c5db3
to
6bbc1d1
Compare
To make QgsNetworkLoggerPanelWidget accessible to applications that builds against QGIS gui