Skip to content

Conversation

domi4484
Copy link
Contributor

@domi4484 domi4484 commented Sep 19, 2025

To make QgsNetworkLoggerPanelWidget accessible to applications that builds against QGIS gui

@github-actions github-actions bot added this to the 4.0.0 milestone Sep 19, 2025
Copy link
Contributor

github-actions bot commented Sep 19, 2025

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This installer is not signed, control+click > open the app to avoid the warning
(Built from commit 6bbc1d1)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 6bbc1d1)

@domi4484 domi4484 force-pushed the networklogger-to-gui branch 9 times, most recently from 668bfbf to 7c0926b Compare September 20, 2025 06:40
Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you motivations to move it in gui module ? especially when you don't enable sip API.

@domi4484
Copy link
Contributor Author

@troopa81 thanks for the review! I would like to use the network logger widget inside an external application that uses QGIS as a library.
As we build directly against the c++ library, we don't need the sip bindings. I thought it was better to not expose all those classes to python if there is no need for it at the moment

@troopa81
Copy link
Contributor

As we build directly against the c++ library, we don't need the sip bindings. I thought it was better to not expose all those classes to python if there is no need for it at the moment

Maybe, yes. I don't know the policy exactly in this kind of situation.

@nyalldawson
Copy link
Collaborator

I thought it was better to not expose all those classes to python if there is no need for it at the moment

I think keeping them out of the bindings is the right move -- there's too much risk of abuse / nasty behavior if we expose these classes for use in Python.

@domi4484 domi4484 force-pushed the networklogger-to-gui branch from 681d58d to ef1ad53 Compare September 23, 2025 21:52
Copy link
Contributor

Tests failed for Qt 6 (ALL_BUT_PROVIDERS - ubuntu)

One or more tests failed using the build from commit ef1ad53

layout_export_marker_masking_w_effects

layout_export_marker_masking_w_effects

Test failed at test_layout_export_marker_masking_w_effects at tests/src/python/test_selective_masking.py:1295

Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_marker_masking_w_effects/layout_export_marker_masking_w_effects.png (found 20 pixels different)

layout_export_marker_masking_w_transparency

layout_export_marker_masking_w_transparency

Test failed at test_layout_export_marker_masking_w_transparency at tests/src/python/test_selective_masking.py:1383

Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_marker_masking_w_transparency/layout_export_marker_masking_w_transparency.png (found 23 pixels different)

layout_export_text_masking_w_transparency

layout_export_text_masking_w_transparency

Test failed at test_layout_export_text_masking_w_transparency at tests/src/python/test_selective_masking.py:1414

Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_text_masking_w_transparency/layout_export_text_masking_w_transparency.png (found 12 pixels different)

layout_export_w_effects

layout_export_w_effects

Test failed at test_layout_export_w_effects at tests/src/python/test_selective_masking.py:1204

Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_w_effects/layout_export_w_effects.png (found 6 pixels different)

layout_export_force_raster_render

layout_export_force_raster_render

Test failed at test_layout_export_w_force_raster_render at tests/src/python/test_selective_masking.py:1357

Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_force_raster_render/layout_export_force_raster_render.png (found 94 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@domi4484 domi4484 marked this pull request as ready for review September 24, 2025 12:58
public:
//! Custom node data roles
enum Roles
enum class Roles
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also move this to Qgis namespace? (and rename to DevToolsNodeRole, and remove "Role" prefix from the values)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done thanks

@domi4484 domi4484 force-pushed the networklogger-to-gui branch 2 times, most recently from 3f0902e to 72c5db3 Compare September 30, 2025 09:55
@domi4484 domi4484 force-pushed the networklogger-to-gui branch from 72c5db3 to 6bbc1d1 Compare September 30, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants