-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Adding "Field Calculator" menu item to the attribute table header right click popup. Fixes #55266 #63287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TurboGraphxBeige
wants to merge
39
commits into
qgis:master
Choose a base branch
from
TurboGraphxBeige:right_click_field_calculator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding "Field Calculator" menu item to the attribute table header right click popup. Fixes #55266 #63287
TurboGraphxBeige
wants to merge
39
commits into
qgis:master
from
TurboGraphxBeige:right_click_field_calculator
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht click popup. Fixes qgis#55266
Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
…ht click popup. Fixes qgis#55266
Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
…ht click popup. Fixes qgis#55266
Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
Well, I don't know how to resolve the 2 failing tests. |
AFAIK the failing PyQgsServerApi test is not related with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new "Field Calculator" menu item in the popup appearing when right clicking in the header of a column in a vector layer's attribute table. The Field Calculator window opens having the "Update existing field" checkbox checked and the corresponding field already selected in the combo box.
The action is enabled or disabled according to the field's possibility to be edited.
This is done by passing an optional field index parameter to QgsFieldCalculator::QgsFieldCalculator constructor (defaults to -1 if null). That makes it like a nice shortcut instead of clicking to open the Field Calculator, then checking "Update existing field" then selected the appropriate field name.
Fixes #55266. Reviving old PR #55293
282995190-6fc02c61-8201-446b-a0a0-4b7536f160e6.mp4