Skip to content

Conversation

alexbruy
Copy link
Contributor

Description

When calculating statistical summary for string field empty strings and NULL values are treated equally, leading to wrong count and count missing values.

Proposed PR fixes this by excluding NULL values from the count and not considering empty strings as missed values, aligning behavior with the numeric statistical summary.

Fixes #35433.

@alexbruy alexbruy added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Sep 24, 2025
@github-actions github-actions bot added this to the 4.0.0 milestone Sep 24, 2025
@alexbruy
Copy link
Contributor Author

@nyalldawson we also have similar issue with the datetime statistical summary, NULLs are included into total count. Should we change it as well?

Copy link
Contributor

github-actions bot commented Sep 24, 2025

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit c1404d7)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This installer is not signed, control+click > open the app to avoid the warning
(Built from commit c1404d7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String aggregate-related functions treat NULL and empty strings interchangeably
2 participants