Skip to content

Commit d9286dc

Browse files
Cleanup and bugfix to support different primitives. (#55) (#855) (#858)
* Cleanup and bugfix for different primitives support (#55) * Quick fix and lint for unit tests. * Fixed a bug in ComputeUncompute and lint corrections. * Fix formatting for algorithm tests * Reformatting some variables to make lint compliant. * Refactor: Cleanup code, preserve existing formatting, apply minor bug fixes, and update missing documentation * Removing unsupported classes. * Fix for lint * Fix lint errors uncovered during workflow checks * Adjust a unit test to accomodate noise-related variations (cherry picked from commit 2f7e19c) Co-authored-by: M. Emre Sahin <40424147+OkuyanBoga@users.noreply.github.com>
1 parent 85ac990 commit d9286dc

26 files changed

+1506
-1792
lines changed

.pylintdict

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,7 @@ platt
390390
polyfit
391391
postprocess
392392
powell
393+
pragma
393394
pre
394395
precompute
395396
precomputed

qiskit_machine_learning/gradients/__init__.py

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,9 @@
2525
:nosignatures:
2626
2727
BaseEstimatorGradient
28-
BaseQGT
2928
BaseSamplerGradient
3029
EstimatorGradientResult
3130
SamplerGradientResult
32-
QGTResult
3331
3432
Linear Combination of Unitaries
3533
-------------------------------
@@ -40,7 +38,6 @@
4038
4139
LinCombEstimatorGradient
4240
LinCombSamplerGradient
43-
LinCombQGT
4441
4542
Parameter Shift Rules
4643
---------------------
@@ -52,16 +49,6 @@
5249
ParamShiftEstimatorGradient
5350
ParamShiftSamplerGradient
5451
55-
Quantum Fisher Information
56-
--------------------------
57-
58-
.. autosummary::
59-
:toctree: ../stubs/
60-
:nosignatures:
61-
62-
QFIResult
63-
QFI
64-
6552
Simultaneous Perturbation Stochastic Approximation
6653
--------------------------------------------------
6754
@@ -74,35 +61,25 @@
7461
"""
7562

7663
from .base.base_estimator_gradient import BaseEstimatorGradient
77-
from .base.base_qgt import BaseQGT
7864
from .base.base_sampler_gradient import BaseSamplerGradient
7965
from .base.estimator_gradient_result import EstimatorGradientResult
8066
from .lin_comb.lin_comb_estimator_gradient import DerivativeType, LinCombEstimatorGradient
81-
from .lin_comb.lin_comb_qgt import LinCombQGT
8267
from .lin_comb.lin_comb_sampler_gradient import LinCombSamplerGradient
8368
from .param_shift.param_shift_estimator_gradient import ParamShiftEstimatorGradient
8469
from .param_shift.param_shift_sampler_gradient import ParamShiftSamplerGradient
85-
from .qfi import QFI
86-
from .qfi_result import QFIResult
87-
from .base.qgt_result import QGTResult
8870
from .base.sampler_gradient_result import SamplerGradientResult
8971
from .spsa.spsa_estimator_gradient import SPSAEstimatorGradient
9072
from .spsa.spsa_sampler_gradient import SPSASamplerGradient
9173

9274
__all__ = [
9375
"BaseEstimatorGradient",
94-
"BaseQGT",
9576
"BaseSamplerGradient",
9677
"DerivativeType",
9778
"EstimatorGradientResult",
9879
"LinCombEstimatorGradient",
99-
"LinCombQGT",
10080
"LinCombSamplerGradient",
10181
"ParamShiftEstimatorGradient",
10282
"ParamShiftSamplerGradient",
103-
"QFI",
104-
"QFIResult",
105-
"QGTResult",
10683
"SamplerGradientResult",
10784
"SPSAEstimatorGradient",
10885
"SPSASamplerGradient",

qiskit_machine_learning/gradients/base/base_estimator_gradient.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ def __init__(
5656
r"""
5757
Args:
5858
estimator: The estimator used to compute the gradients.
59-
pass_manager: pass manager for isa_circuit transpilation.
6059
options: Primitive backend runtime options used for circuit execution.
6160
The order of priority is: options in ``run`` method > gradient's
6261
default options > primitive's default setting.
@@ -71,6 +70,8 @@ def __init__(
7170
Defaults to ``DerivativeType.REAL``, as this yields e.g. the commonly-used energy
7271
gradient and this type is the only supported type for function-level schemes like
7372
finite difference.
73+
pass_manager: The pass manager to transpile the circuits if necessary.
74+
Defaults to ``None``, as some primitives do not need transpiled circuits.
7475
"""
7576
if isinstance(estimator, BaseEstimatorV1):
7677
issue_deprecation_msg(

0 commit comments

Comments
 (0)