JVickery-TBS:feature/validation support #113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add config option for resources to require validation. - Only submit to xloader if validation is successful.
- Added debug logging.
- Do not use 2.10+ helper.
- Check toolkit action instead of plugin name.
- Added method docs to explain new method.
# Conflicts: # ckanext/xloader/plugin.py ### RESOLVED.
- Fixed typo. - Fixed try/catch.
- Prevent POST to upload to DS if validation is required. - flake8 if wrap indents.
- Syntax fixes from flake8.
- Moved logic into util method. - Renamed config options. - Added new config option to enforce validation schema existance.
# Conflicts: # ckanext/xloader/plugin.py # ckanext/xloader/utils.py ### RESOLVED.
- Added automated tests. - Changed the logic to be better and more clear.
- Fixed a logic case.
# Conflicts: # ckanext/xloader/config_declaration.yaml # ckanext/xloader/plugin.py # ckanext/xloader/tests/test_plugin.py ### RESOLVED.
- Better conditional syntax.
- Fixed inline comments to make more sense.
- Started doing sync mode for xloader right after validation.
- Continued sync mode chaining from validation.
- Continued sync mode chaining from validation.
# Conflicts: # ckanext/xloader/action.py ### RESOLVED.
- Implement experimental `IPipeValidation` implement.
- Cannot do tests without `IPipeValidation`.
- Clearer comments. - Clearer log messages.
- Added `ignore_not_sysadmin` validator to the sync key.
ThrawnCA
requested changes
Oct 25, 2024
| if sync: | ||
| log.exception('Unable to xloader res_id=%s', res_id) | ||
| else: | ||
| log.exception('Unable to enqueued xloader res_id=%s', res_id) |
| sync = toolkit.asbool(toolkit.config.get(u'ckanext.validation.run_on_update_async', True)) | ||
| self._submit_to_xloader(res_dict, sync=sync) | ||
|
|
||
|
|
There was a problem hiding this comment.
Flake8 generally prefers single blank lines inside a class.
|
already merged via upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing final differences of what is in our version to what is going to upstream (prior to merging ckan#200 )