Skip to content

Add tag_transformers remove_tags, index_tags. #7306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

babacry
Copy link
Collaborator

@babacry babacry commented Apr 30, 2025

  • remove tags: remove given tags via either target_tags or remove_if fn.

  • Index tags: iterate the whole circuit and index the same tags with sub_ids, e.g.,

X["tag"]-Y["tag"]  --transformer.index_tags(target_tags={"tag"})--> X["tag_0"]--Y["tag_1"]

Context: to be used in #6994.

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (2635656) to head (c69be2a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7306      +/-   ##
==========================================
- Coverage   98.67%   98.67%   -0.01%     
==========================================
  Files        1109     1111       +2     
  Lines       96863    96924      +61     
==========================================
+ Hits        95580    95636      +56     
- Misses       1283     1288       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added size: L 250< lines changed <1000 and removed size: M 50< lines changed <250 labels Apr 30, 2025
@babacry babacry removed the request for review from viathor May 1, 2025 01:54
@babacry
Copy link
Collaborator Author

babacry commented May 1, 2025

@NoureldinYosri Tag transformers! could you help reivew?

Copy link
Collaborator

@NoureldinYosri NoureldinYosri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @babacry ... great work

@NoureldinYosri NoureldinYosri added this pull request to the merge queue May 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 5, 2025
@babacry babacry enabled auto-merge May 7, 2025 22:21
@babacry babacry added this pull request to the merge queue May 7, 2025
Merged via the queue into quantumlib:main with commit b136ae8 May 7, 2025
38 of 39 checks passed
@babacry babacry deleted the tag_trans branch May 7, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants